Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: net/http/http_auth_handler_basic.h

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler.cc ('k') | net/http/http_auth_handler_basic.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_basic.h
diff --git a/net/http/http_auth_handler_basic.h b/net/http/http_auth_handler_basic.h
index 186caf68304c01da616c1d20a37b7c6edeb5023e..4f369cc3ddb7f23e629b9ee6cdf280b64927350a 100644
--- a/net/http/http_auth_handler_basic.h
+++ b/net/http/http_auth_handler_basic.h
@@ -21,7 +21,7 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerBasic : public HttpAuthHandler {
Factory();
~Factory() override;
- int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,
+ int CreateAuthHandler(const HttpAuthChallengeTokenizer& challenge,
HttpAuth::Target target,
const GURL& origin,
CreateReason reason,
@@ -31,20 +31,20 @@ class NET_EXPORT_PRIVATE HttpAuthHandlerBasic : public HttpAuthHandler {
};
HttpAuth::AuthorizationResult HandleAnotherChallenge(
- HttpAuthChallengeTokenizer* challenge) override;
+ const HttpAuthChallengeTokenizer& challenge) override;
protected:
- bool Init(HttpAuthChallengeTokenizer* challenge) override;
+ int Init(const HttpAuthChallengeTokenizer& challenge) override;
int GenerateAuthTokenImpl(const AuthCredentials* credentials,
- const HttpRequestInfo* request,
+ const HttpRequestInfo& request,
const CompletionCallback& callback,
std::string* auth_token) override;
private:
~HttpAuthHandlerBasic() override {}
- bool ParseChallenge(HttpAuthChallengeTokenizer* challenge);
+ int ParseChallenge(const HttpAuthChallengeTokenizer& challenge);
};
} // namespace net
« no previous file with comments | « net/http/http_auth_handler.cc ('k') | net/http/http_auth_handler_basic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698