[net/http auth] Cleanup. Method names, and constness.

net/android/http_auth_negotiate_android.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_ANDROID_HTTP_AUTH_NEGOTIATE_ANDROID_H_
 #define NET_ANDROID_HTTP_AUTH_NEGOTIATE_ANDROID_H_
 
 #include <jni.h>
 #include <string>
 
@@ skipping 57 matching lines @@
   bool Init();
 
   // True if authentication needs the identity of the user from Chrome.
   bool NeedsIdentity() const;
 
   // True authentication can use explicit credentials included in the URL.
   bool AllowsExplicitCredentials() const;
 
   // Parse a received Negotiate challenge.
   HttpAuth::AuthorizationResult ParseChallenge(
-      net::HttpAuthChallengeTokenizer* tok);
+      const HttpAuthChallengeTokenizer& tok);
 
   // Generates an authentication token.
   //
   // The return value is an error code. The authentication token will be
   // returned in |*auth_token|. If the result code is not |OK|, the value of
   // |*auth_token| is unspecified.
   //
   // If the operation cannot be completed synchronously, |ERR_IO_PENDING| will
   // be returned and the real result code will be passed to the completion
   // callback.  Otherwise the result code is returned immediately from this
   // call.
   //
   // If the AndroidAuthNegotiate object is deleted before completion then the
   // callback will not be called.
   //
   // If no immediate result is returned then |auth_token| must remain valid
   // until the callback has been called.
   //
   // |spn| is the Service Principal Name of the server that the token is
   // being generated for.
   //
   // If this is the first round of a multiple round scheme, credentials are
   // obtained using |*credentials|. If |credentials| is NULL, the default
   // credentials are used instead.
   int GenerateAuthToken(const AuthCredentials* credentials,
                         const std::string& spn,
                         std::string* auth_token,
-                        const net::CompletionCallback& callback);
+                        const CompletionCallback& callback);
 
   // Delegation is allowed on the Kerberos ticket. This allows certain servers
   // to act as the user, such as an IIS server retrieving data from a
   // Kerberized MSSQL server.
   void Delegate();
 
  private:
   void SetResultInternal(int result, const std::string& token);
 
   std::string account_type_;
   bool can_delegate_;
   bool first_challenge_;
   std::string server_auth_token_;
   std::string* auth_token_;
   base::android::ScopedJavaGlobalRef<jobject> java_authenticator_;
   net::CompletionCallback completion_callback_;
 
   base::WeakPtrFactory<HttpAuthNegotiateAndroid> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpAuthNegotiateAndroid);
 };
 
 }  // namespace android
 }  // namespace net
 
 #endif  // NET_ANDROID_HTTP_AUTH_NEGOTIATE_ANDROID_H_