runtime/vm/locations.h - Issue 1383573002: VM: More compact code for pushing constant arguments on ia32/x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/locations.h

Issue 1383573002: VM: More compact code for pushing constant arguments on ia32/x64. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/locations.h

diff --git a/runtime/vm/locations.h b/runtime/vm/locations.h

index 5e92c1612aeb2479b821c8be586eaba67df4f0f6..047b66339cb3968501a3841336c6531864378fe8 100644

--- a/runtime/vm/locations.h

+++ b/runtime/vm/locations.h

@@ -148,7 +148,7 @@ class Location : public ValueObject {

return (value_ & kLocationTagMask) == kConstantTag;

}

- static Location Constant(ConstantInstr* obj) {

+ static Location Constant(const ConstantInstr* obj) {

Location loc(reinterpret_cast<uword>(obj) | kConstantTag);

ASSERT(obj == loc.constant_instruction());

return loc;