Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1383553002: Reland "Clean up rewriter" (issue 1362333002). (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Clean up rewriter" (issue 1362333002). R=rossberg BUG= Committed: https://crrev.com/66660ab02b0784dd57bba0cb953b61fe7549c1d5 Cr-Commit-Position: refs/heads/master@{#31022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -45 lines) Patch
M src/rewriter.cc View 6 chunks +33 lines, -35 lines 0 comments Download
M test/webkit/eval-throw-return.js View 1 chunk +5 lines, -5 lines 0 comments Download
M test/webkit/eval-throw-return-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
neis
5 years, 2 months ago (2015-09-30 14:09:31 UTC) #1
rossberg
lgtm
5 years, 2 months ago (2015-09-30 14:19:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383553002/1
5 years, 2 months ago (2015-09-30 14:20:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 14:43:23 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 14:43:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66660ab02b0784dd57bba0cb953b61fe7549c1d5
Cr-Commit-Position: refs/heads/master@{#31022}

Powered by Google App Engine
This is Rietveld 408576698