[DevTools] Show a explanation when all resources in the page have been requested securely (no-mixed…

third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.PanelWithSidebar}
  * @implements {WebInspector.TargetManager.Observer}
  */
 WebInspector.SecurityPanel = function()
@@ skipping 521 matching lines @@
         if (!this._schemeIsCryptographic)
             return;
 
         if (this._mixedContentStatus && (this._mixedContentStatus.ranInsecureContent || this._mixedContentStatus.displayedInsecureContent)) {
             if (this._mixedContentStatus.ranInsecureContent)
                 this._addMixedContentExplanation(this._mixedContentStatus.ranInsecureContentStyle, WebInspector.UIString("Active Mixed Content"), WebInspector.UIString("You have recently allowed insecure content (such as scripts or iframes) to run on this site."), WebInspector.NetworkLogView.MixedContentFilterValues.BlockOverridden, showBlockOverriddenMixedContentInNetworkPanel);
             if (this._mixedContentStatus.displayedInsecureContent)
                 this._addMixedContentExplanation(this._mixedContentStatus.displayedInsecureContentStyle, WebInspector.UIString("Mixed Content"), WebInspector.UIString("The site includes HTTP resources."), WebInspector.NetworkLogView.MixedContentFilterValues.Displayed, showDisplayedMixedContentInNetworkPanel);
         }
 
+        if (this._mixedContentStatus && (!this._mixedContentStatus.displayedInsecureContent && !this._mixedContentStatus.ranInsecureContent)) {
+              this._addMixedContentExplanation(SecurityAgent.SecurityState.Secure, WebInspector.UIString("Secure Resources"), WebInspector.UIString("All resources on this page are served securely."));

[lgarron, 2015/10/09 00:16:31]

I'm a bit split on this. On the one hand, this patch complicates
_addMixedContentExplanation in order to allow it to handle this case as if it
were just:


            this._addExplanation(/** @type
{!SecurityAgent.SecurityStateExplanation} */ ({
                "securityState": SecurityAgent.SecurityState.Secure,
                "summary": WebInspector.UIString("Secure Resources"),
                "description": WebInspector.UIString("All resources on this page
are served securely.")
            }));

On the other hand, calling _addMixedContentExplanation for all mixed content
states makes sense if we want to do something special for mixed content
explanations (e.g. styling). On the third hand, we don't do that kind of styling
right now, and I don't feel we need to set up our code to guard for it.
On the fourth hand, now that it's written, it doesn't hurt.

So what I'm saying is that I guess I'm okay with it. :-P

[dgozman, 2015/10/09 03:52:54]

I think it's better to use |_addExplanation| here.

+        }
+
         if (this._panel.filterRequestCount(WebInspector.NetworkLogView.MixedContentFilterValues.Blocked) > 0)
             this._addMixedContentExplanation(SecurityAgent.SecurityState.Info, WebInspector.UIString("Blocked mixed content"), WebInspector.UIString("Your page requested insecure resources that were blocked."), WebInspector.NetworkLogView.MixedContentFilterValues.Blocked, showBlockedMixedContentInNetworkPanel);
 
         /**
          * @param {!Event} e
          */
         function showDisplayedMixedContentInNetworkPanel(e)
         {
             e.consume();
             WebInspector.NetworkPanel.revealAndFilter(WebInspector.NetworkLogView.FilterType.MixedContent, WebInspector.NetworkLogView.MixedContentFilterValues.Displayed);
@@ skipping 15 matching lines @@
         {
             e.consume();
             WebInspector.NetworkPanel.revealAndFilter(WebInspector.NetworkLogView.FilterType.MixedContent, WebInspector.NetworkLogView.MixedContentFilterValues.Blocked);
         }
     },
 
     /**
      * @param {!SecurityAgent.SecurityState} securityState
      * @param {string} summary
      * @param {string} description
-     * @param {!WebInspector.NetworkLogView.MixedContentFilterValues} filterKey
-     * @param {!Function} networkFilterFn
+     * @param {!WebInspector.NetworkLogView.MixedContentFilterValues=} filterKey
+     * @param {!Function=} networkFilterFn
      */
     _addMixedContentExplanation: function(securityState, summary, description, filterKey, networkFilterFn)
     {
         var mixedContentExplanation = /** @type {!SecurityAgent.SecurityStateExplanation} */ ({
             "securityState": securityState,
             "summary": summary,
             "description": description
         });
 
+        var explanation = this._addExplanation(mixedContentExplanation);
+
+        if (!filterKey || !networkFilterFn) { return; }

[dgozman, 2015/10/09 03:52:54]

nit: drop {} and place return on next line.

+
         var filterRequestCount = this._panel.filterRequestCount(filterKey);
-        var requestsAnchor = this._addExplanation(mixedContentExplanation).createChild("div", "security-mixed-content link");
+        var requestsAnchor = explanation.createChild("div", "security-mixed-content link");
         if (filterRequestCount > 0) {
             requestsAnchor.textContent = WebInspector.UIString("View %d request%s in Network Panel", filterRequestCount, (filterRequestCount > 1 ? "s" : ""));
         } else {
             // Network instrumentation might not have been enabled for the page load, so the security panel does not necessarily know a count of individual mixed requests at this point. Point the user at the Network Panel which prompts them to refresh.
             requestsAnchor.textContent = WebInspector.UIString("View requests in Network Panel");
         }
         requestsAnchor.href = "";
         requestsAnchor.addEventListener("click", networkFilterFn);
     },
 
@@ skipping 165 matching lines @@
         row.createChild("div").textContent = WebInspector.UIString(key);
 
         var valueDiv = row.createChild("div");
         if (value instanceof HTMLDivElement) {
             valueDiv.appendChild(value);
         } else {
             valueDiv.textContent = value;
         }
     }
 }