Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/browser/extensions/api/webrtc_from_web_accessible_resource_browsertest.cc

Issue 1383483007: Add scheme exceptions for isSecureContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Nits and fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/command_line.h"
6 #include "chrome/browser/extensions/extension_apitest.h"
7 #include "chrome/browser/ui/tabs/tab_strip_model.h"
8 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
9 #include "chrome/common/chrome_switches.h"
10 #include "chrome/test/base/ui_test_utils.h"
11 #include "content/public/common/content_switches.h"
12 #include "media/base/media_switches.h"
13 #include "net/dns/mock_host_resolver.h"
14 #include "net/test/embedded_test_server/embedded_test_server.h"
15
16 namespace extensions {
17
18 namespace {
19
20 // Used to observe the creation of permission prompt without responding.
21 class PermissionRequestObserver : public PermissionBubbleManager::Observer {
22 public:
23 explicit PermissionRequestObserver(content::WebContents* web_contents)
24 : bubble_manager_(PermissionBubbleManager::FromWebContents(web_contents)),
25 request_shown_(false),
26 message_loop_runner_(new content::MessageLoopRunner) {
27 bubble_manager_->AddObserver(this);
28 }
29 ~PermissionRequestObserver() override {
30 // Safe to remove twice if it happens.
31 bubble_manager_->RemoveObserver(this);
32 }
33
34 void Wait() { message_loop_runner_->Run(); }
35
36 bool request_shown() const { return request_shown_; }
37
38 private:
39 // PermissionBubbleManager::Observer
40 void OnBubbleAdded() override {
41 request_shown_ = true;
42 bubble_manager_->RemoveObserver(this);
43 message_loop_runner_->Quit();
44 }
45
46 PermissionBubbleManager* bubble_manager_;
47 bool request_shown_;
48 scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
49
50 DISALLOW_COPY_AND_ASSIGN(PermissionRequestObserver);
51 };
52
53 } // namespace
54
55 class WebRtcFromWebAccessibleResourceTest : public ExtensionApiTest {
56 public:
57 WebRtcFromWebAccessibleResourceTest() {}
58 ~WebRtcFromWebAccessibleResourceTest() override {}
59
60 // InProcessBrowserTest:
61 void SetUpCommandLine(base::CommandLine* command_line) override {
62 ExtensionApiTest::SetUpCommandLine(command_line);
63
64 // This test expects to run with fake devices and fake UI.
65 command_line->AppendSwitch(switches::kUseFakeDeviceForMediaStream);
66 command_line->AppendSwitch(switches::kUseFakeUIForMediaStream);
67 }
68
69 private:
70 DISALLOW_COPY_AND_ASSIGN(WebRtcFromWebAccessibleResourceTest);
71 };
72
73 // Flaky on Windows: http://crbug.com/301887
Devlin 2015/10/08 16:48:32 Why are newly-added tests already flaky? :)
jww 2015/10/09 21:39:26 Whoops, leftovers from when I first started trying
74 #if defined(OS_WIN)
75 #define MAYBE_GetUserMediaInWebAccessibleResource \
76 DISABLED_GetUserMediaInWebAccessibleResource
77 #else
78 #define MAYBE_GetUserMediaInWebAccessibleResource \
79 GetUserMediaInWebAccessibleResource
80 #endif
81 IN_PROC_BROWSER_TEST_F(WebRtcFromWebAccessibleResourceTest,
82 MAYBE_GetUserMediaInWebAccessibleResource) {
83 host_resolver()->AddRule("a.com", "127.0.0.1");
84 ASSERT_TRUE(StartEmbeddedTestServer());
85
86 content::WebContents* web_contents =
87 browser()->tab_strip_model()->GetActiveWebContents();
88 PermissionBubbleManager::FromWebContents(web_contents)
89 ->set_auto_response_for_test(PermissionBubbleManager::ACCEPT_ALL);
90 ASSERT_TRUE(RunExtensionTest("webrtc_from_web_accessible_resource"))
Devlin 2015/10/08 16:48:32 For funzies, we should also add PermissionBubbleMa
jww 2015/10/09 21:39:26 Good call. Added.
91 << message_;
92 }
93
94 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698