Add scheme exceptions for isSecureContext

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 5638 matching lines @@
 {
     wrapper = V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperType, wrapper);
     DOMWrapperWorld& world = DOMWrapperWorld::current(isolate);
     if (world.isMainWorld() && frame())
         frame()->script().windowProxy(world)->updateDocumentWrapper(wrapper);
     return wrapper;
 }
 
 bool Document::isSecureContext(String& errorMessage, const SecureContextCheck privilegeContextCheck) const
 {
+    // There may be exceptions for the secure context check defined for
+    // certain origins. The exceptions are applied only to the origin
+    // themselves and to immediate sanbox frame descendants, but *not* to

[robwu, 2015/10/03 19:28:51]

sanbox -> sandbox

[jww, 2015/10/06 21:53:55]

Done.

+    // any other children. For example:
+    //   <iframe src="scheme://this-origin-has-exception">
+    //     <iframe sandbox srcdoc="..."></iframe>

[robwu, 2015/10/03 19:28:51]

This does not pass the check because the URL of the frame is about:srcdoc, not
scheme://this-origin-has-exception. If you want to allow about:srcdoc and
about:blank frames to pass the check, then you have to traverse the frame tree
in the loop below.

[jww, 2015/10/06 21:53:56]

Hm, no, I don't want that to pass; I'm not sure what I was getting at with this
note. I'll simplify it.

+    //   </iframe>
+    // would pass this check, both for the outer frame and the inner frame,
+    // assuming that the origin "scheme://this-origin-has-exception" is granted
+    // an exception. However,
+    //   <iframe src="scheme://this-origin-has-exception">
+    //     <iframe src="http://a.b/"></iframe>
+    //   </iframe>
+    // the inner frame "http://a.b/" would *not* pass the check, even though
+    // the parent frame has an exception.
+    // In all cases, a frame must be potentially trustworthy in addition to
+    // having an exception listed in order for the exception to be granted.
     if (SecurityContext::isSandboxed(SandboxOrigin)) {
-        if (!SecurityOrigin::create(url())->isPotentiallyTrustworthy(errorMessage))
+        RefPtr<SecurityOrigin> origin = SecurityOrigin::create(url());
+        if (!origin->isPotentiallyTrustworthy(errorMessage))
             return false;
+        if (SecurityPolicy::shouldOriginBypassSecureContextCheck(*origin))
+            return true;
     } else {
         if (!securityOrigin()->isPotentiallyTrustworthy(errorMessage))
             return false;
+        if (SecurityPolicy::shouldOriginBypassSecureContextCheck(*securityOrigin()))
+            return true;
     }
 
     if (privilegeContextCheck == StandardSecureContextCheck) {
         Document* context = parentDocument();
         while (context) {
             // Skip to the next ancestor if it's a srcdoc.
             if (!context->isSrcdocDocument()) {
                 if (context->securityContext().isSandboxed(SandboxOrigin)) {
                     // For a sandboxed origin, use the document's URL.
                     RefPtr<SecurityOrigin> origin = SecurityOrigin::create(context->url());
@@ skipping 82 matching lines @@
 #ifndef NDEBUG
 using namespace blink;
 void showLiveDocumentInstances()
 {
     Document::WeakDocumentSet& set = Document::liveDocumentSet();
     fprintf(stderr, "There are %u documents currently alive:\n", set.size());
     for (Document* document : set)
         fprintf(stderr, "- Document %p URL: %s\n", document, document->url().string().utf8().data());
 }
 #endif