Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1383483004: Add cstdarg header to log-utils.h (Closed)

Created:
5 years, 2 months ago by dsinclair
Modified:
5 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add cstdarg header to log-utils.h The log-utils.h file uses va_list but doesn't require the header. This CL adds the needed header to remove a compiler error we've seen when doing some bisecting. Committed: https://crrev.com/e89226a549d73529aff5ed05d84e44bc1945b347 Cr-Commit-Position: refs/heads/master@{#31110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/log-utils.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dsinclair
PTAL.
5 years, 2 months ago (2015-10-01 20:16:35 UTC) #2
adamk
lgtm
5 years, 2 months ago (2015-10-05 17:44:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383483004/1
5 years, 2 months ago (2015-10-05 17:45:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 18:54:03 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 18:54:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e89226a549d73529aff5ed05d84e44bc1945b347
Cr-Commit-Position: refs/heads/master@{#31110}

Powered by Google App Engine
This is Rietveld 408576698