Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1383473002: [swarming] Only isolate d8 with target toolset. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
M-A Ruel, v8-reviews_googlegroups.com, jbudorick, ghost stip (do not use)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Only isolate d8 with target toolset. BUG=chromium:535160, chromium:537247 LOG=n Committed: https://crrev.com/9a03979dc934586eae4787a242a0d1bd48ef8b5a Cr-Commit-Position: refs/heads/master@{#31020}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/d8.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
Michael Achenbach
PTAL
5 years, 2 months ago (2015-09-30 13:01:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383473002/20001
5 years, 2 months ago (2015-09-30 13:16:05 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-09-30 13:28:44 UTC) #5
M-A Ruel
cc: Mostyn lgtm, this had also broken http://build.chromium.org/p/chromium.swarm/builders/Android%20Swarm/builds/2152/steps/gclient%20runhooks/logs/stdio
5 years, 2 months ago (2015-09-30 13:30:43 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 13:37:52 UTC) #9
Mostyn Bramley-Moore
This patch WFM.
5 years, 2 months ago (2015-09-30 13:40:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383473002/20001
5 years, 2 months ago (2015-09-30 13:44:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383473002/20001
5 years, 2 months ago (2015-09-30 13:45:00 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 13:48:14 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 13:48:34 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9a03979dc934586eae4787a242a0d1bd48ef8b5a
Cr-Commit-Position: refs/heads/master@{#31020}

Powered by Google App Engine
This is Rietveld 408576698