Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 138343008: Add content implementation of digestSynchcronous. (Closed)

Created:
6 years, 10 months ago by jww
Modified:
6 years, 10 months ago
Reviewers:
eroman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, abarth-chromium
Visibility:
Public.

Description

Add content implementation of digestSynchcronous. BUG=327826 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252783

Patch Set 1 #

Patch Set 2 : Removed extra return #

Patch Set 3 : Updated for simlified digestSynchronous API #

Patch Set 4 : Updated arguments. #

Patch Set 5 : Rebased on ToT #

Total comments: 10

Patch Set 6 : Fixes from eroman #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M content/renderer/webcrypto/webcrypto_impl.h View 1 2 3 4 5 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl.cc View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jww
This is dependent on the Blink CL: https://codereview.chromium.org/151673005/ I wasn't entirely sure of the best ...
6 years, 10 months ago (2014-02-07 23:24:17 UTC) #1
jww
This is updated with the simplified digestSychronous API in CL https://codereview.chromium.org/151673005/. These changes actually answer ...
6 years, 10 months ago (2014-02-08 00:44:55 UTC) #2
jww
6 years, 10 months ago (2014-02-08 02:32:30 UTC) #3
jww
On 2014/02/08 02:32:30, jww wrote: Hi eroman. Now that the Blink CL is in, let ...
6 years, 10 months ago (2014-02-19 02:24:42 UTC) #4
jww
6 years, 10 months ago (2014-02-20 01:02:40 UTC) #5
eroman
https://codereview.chromium.org/138343008/diff/170001/content/renderer/webcrypto/webcrypto_impl.cc File content/renderer/webcrypto/webcrypto_impl.cc (right): https://codereview.chromium.org/138343008/diff/170001/content/renderer/webcrypto/webcrypto_impl.cc#newcode197 content/renderer/webcrypto/webcrypto_impl.cc:197: // This method synchronously computes a digest for the ...
6 years, 10 months ago (2014-02-21 23:11:20 UTC) #6
jww
https://codereview.chromium.org/138343008/diff/170001/content/renderer/webcrypto/webcrypto_impl.cc File content/renderer/webcrypto/webcrypto_impl.cc (right): https://codereview.chromium.org/138343008/diff/170001/content/renderer/webcrypto/webcrypto_impl.cc#newcode197 content/renderer/webcrypto/webcrypto_impl.cc:197: // This method synchronously computes a digest for the ...
6 years, 10 months ago (2014-02-21 23:23:33 UTC) #7
eroman
lgtm
6 years, 10 months ago (2014-02-21 23:39:05 UTC) #8
jww
The CQ bit was checked by jww@chromium.org
6 years, 10 months ago (2014-02-22 00:39:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/138343008/240001
6 years, 10 months ago (2014-02-22 00:39:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/138343008/240001
6 years, 10 months ago (2014-02-22 01:33:57 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 08:32:57 UTC) #12
Message was sent while issue was closed.
Change committed as 252783

Powered by Google App Engine
This is Rietveld 408576698