Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Side by Side Diff: Source/core/html/HTMLCollection.cpp

Issue 138343007: Use more consistent naming for caching methods in NodeListsNodeData class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/TagCollection.cpp ('k') | Source/core/html/HTMLNameCollection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All r ights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All r ights reserved.
5 * Copyright (C) 2014 Samsung Electronics. All rights reserved. 5 * Copyright (C) 2014 Samsung Electronics. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 PassRefPtr<HTMLCollection> HTMLCollection::create(ContainerNode* base, Collectio nType type) 172 PassRefPtr<HTMLCollection> HTMLCollection::create(ContainerNode* base, Collectio nType type)
173 { 173 {
174 return adoptRef(new HTMLCollection(base, type, DoesNotOverrideItemAfter)); 174 return adoptRef(new HTMLCollection(base, type, DoesNotOverrideItemAfter));
175 } 175 }
176 176
177 HTMLCollection::~HTMLCollection() 177 HTMLCollection::~HTMLCollection()
178 { 178 {
179 // HTMLNameCollection, ClassCollection and TagCollection remove cache by the mselves. 179 // HTMLNameCollection, ClassCollection and TagCollection remove cache by the mselves.
180 if (type() != WindowNamedItems && type() != DocumentNamedItems && type() != ClassCollectionType 180 if (type() != WindowNamedItems && type() != DocumentNamedItems && type() != ClassCollectionType
181 && type() != HTMLTagCollectionType && type() != TagCollectionType) { 181 && type() != HTMLTagCollectionType && type() != TagCollectionType) {
182 ownerNode()->nodeLists()->removeCacheWithAtomicName(this, type()); 182 ownerNode()->nodeLists()->removeCache(this, type());
183 } 183 }
184 } 184 }
185 185
186 void HTMLCollection::invalidateCache() const 186 void HTMLCollection::invalidateCache() const
187 { 187 {
188 m_collectionIndexCache.invalidate(); 188 m_collectionIndexCache.invalidate();
189 invalidateIdNameCacheMaps(); 189 invalidateIdNameCacheMaps();
190 } 190 }
191 191
192 template <class NodeListType> 192 template <class NodeListType>
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 569
570 void HTMLCollection::append(NodeCacheMap& map, const AtomicString& key, Element* element) 570 void HTMLCollection::append(NodeCacheMap& map, const AtomicString& key, Element* element)
571 { 571 {
572 OwnPtr<Vector<Element*> >& vector = map.add(key.impl(), nullptr).iterator->v alue; 572 OwnPtr<Vector<Element*> >& vector = map.add(key.impl(), nullptr).iterator->v alue;
573 if (!vector) 573 if (!vector)
574 vector = adoptPtr(new Vector<Element*>); 574 vector = adoptPtr(new Vector<Element*>);
575 vector->append(element); 575 vector->append(element);
576 } 576 }
577 577
578 } // namespace WebCore 578 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/TagCollection.cpp ('k') | Source/core/html/HTMLNameCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698