Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138343004: Add time online histograms for VPN usage (Closed)

Created:
6 years, 11 months ago by Paul Stewart
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, thieule
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add time online histograms for VPN usage The capitalization on two of the histograms were wrong, and it was missing a TimeOnline value. R=isherman@chromium.org BUG=209709 TEST=Start chrome, and browse to chrome://histograms to make sure these enums now exist after starting a VPN connection. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245168

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add additional details on how histogram is generated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paul Stewart
6 years, 11 months ago (2014-01-14 22:10:47 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/138343004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/138343004/diff/1/tools/metrics/histograms/histograms.xml#newcode11235 tools/metrics/histograms/histograms.xml:11235: Mention when/how often this is sampled.
6 years, 11 months ago (2014-01-14 22:20:04 UTC) #2
Paul Stewart
https://codereview.chromium.org/138343004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/138343004/diff/1/tools/metrics/histograms/histograms.xml#newcode11235 tools/metrics/histograms/histograms.xml:11235: On 2014/01/14 22:20:05, Alexei Svitkine wrote: > Mention when/how ...
6 years, 11 months ago (2014-01-14 22:46:48 UTC) #3
Alexei Svitkine (slow)
LGTM
6 years, 11 months ago (2014-01-14 22:48:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pstew@chromium.org/138343004/110002
6 years, 11 months ago (2014-01-15 04:58:01 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 06:26:31 UTC) #6
Message was sent while issue was closed. 
Change committed as 245168

Powered by Google App Engine
This is Rietveld 408576698