Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 138343003: Output the subkey type for list policies on the plist generator. (Closed)

Created:
6 years, 11 months ago by Joao da Silva
Modified:
6 years, 11 months ago
Reviewers:
pastarmovj
CC:
grit-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master
Visibility:
Public.

Description

Output the subkey type for list policies on the plist generator. BUG=61734 R=pastarmovj@chromium.org Committed: https://code.google.com/p/grit-i18n/source/detail?r=146

Patch Set 1 #

Patch Set 2 : fix upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M grit/format/policy_templates/writers/plist_writer.py View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
Hey Julian, please have a look at this when you're back. See the bug for ...
6 years, 11 months ago (2014-01-14 15:29:11 UTC) #1
bartfab (slow)
On 2014/01/14 15:29:11, Joao da Silva wrote: > Hey Julian, please have a look at ...
6 years, 11 months ago (2014-01-14 15:38:58 UTC) #2
Joao da Silva
Thanks for the heads up. Uploaded the patch again
6 years, 11 months ago (2014-01-14 15:48:18 UTC) #3
pastarmovj
lgtm
6 years, 11 months ago (2014-01-15 10:45:06 UTC) #4
Joao da Silva
6 years, 11 months ago (2014-01-15 10:54:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698