Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 138333005: Add missing test targets to chrome_official_builder for Windows. (Closed)

Created:
6 years, 11 months ago by Paweł Hajdan Jr.
Modified:
6 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Add missing test targets to chrome_official_builder for Windows. BUG=334006 R=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M build/all.gyp View 1 chunk +18 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
6 years, 11 months ago (2014-01-14 22:35:37 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 11 months ago (2014-01-16 02:56:44 UTC) #2
Paweł Hajdan Jr.
Committed patchset #1 manually as r245379 (presubmit successful).
6 years, 11 months ago (2014-01-16 23:49:17 UTC) #3
scottmg
6 years, 10 months ago (2014-01-31 16:38:59 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/151413006/ by scottmg@chromium.org.

The reason for reverting is: These were removed because the toolchain can no
longer link them..

Powered by Google App Engine
This is Rietveld 408576698