Issue 1383313002: Move completion APIs to a private location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1383313002: Move completion APIs to a private location (Closed)

Created:
5 years, 2 months ago by Brian Wilkerson

Modified:
5 years, 2 months ago

Reviewers:
scheglov, danrubel

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Move completion APIs to private location R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7bbd8c66a59a406f1336e3d73fd370e8a42d83f2

Patch Set 1 #

Patch Set 2 : formatting #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -613 lines)			Patch
D	pkg/analysis_server/lib/completion/completion_core.dart	View		1 chunk	+0 lines, -84 lines	0 comments	Download
D	pkg/analysis_server/lib/completion/completion_dart.dart	View		1 chunk	+0 lines, -88 lines	0 comments	Download
D	pkg/analysis_server/lib/completion/dart/completion_target.dart	View		1 chunk	+0 lines, -356 lines	0 comments	Download
D	pkg/analysis_server/lib/plugin/completion.dart	View		1 chunk	+0 lines, -39 lines	0 comments	Download
M	pkg/analysis_server/lib/src/domain_completion.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/plugin/server_plugin.dart	View		2 chunks	+1 line, -1 line	0 comments	Download
A +	pkg/analysis_server/lib/src/provisional/completion/completion.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	pkg/analysis_server/lib/src/provisional/completion/completion_core.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/analysis_server/lib/src/provisional/completion/completion_dart.dart	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download
A +	pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/completion_core.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/completion_dart.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/completion_manager.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/contribution_sorter.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/inherited_contributor.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/optype.dart	View		3 chunks	+11 lines, -11 lines	0 comments	Download
M	pkg/analysis_server/test/domain_completion_test.dart	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/completion_computer_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/completion_target_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/completion/completion_test_util.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/completion/optype_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

5 years, 2 months ago (2015-10-05 18:57:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7bbd8c66a59a406f1336e3d73fd370e8a42d83f2 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages