Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x.h

Issue 1383303002: Use kwalletd5 in KDE 5 environments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_kwallet_x.h
diff --git a/chrome/browser/password_manager/native_backend_kwallet_x.h b/chrome/browser/password_manager/native_backend_kwallet_x.h
index 3b0524e462e5e5a1eb251a8df14c751865c6c794..f295f3a7a3752734444a64661dff805a48349a96 100644
--- a/chrome/browser/password_manager/native_backend_kwallet_x.h
+++ b/chrome/browser/password_manager/native_backend_kwallet_x.h
@@ -11,6 +11,7 @@
#include "base/compiler_specific.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_vector.h"
+#include "base/nix/xdg_util.h"
#include "base/time/time.h"
#include "chrome/browser/password_manager/password_store_factory.h"
#include "chrome/browser/password_manager/password_store_x.h"
@@ -34,7 +35,8 @@ class ObjectProxy;
// NativeBackend implementation using KWallet.
class NativeBackendKWallet : public PasswordStoreX::NativeBackend {
public:
- explicit NativeBackendKWallet(LocalProfileId id);
+ explicit NativeBackendKWallet(LocalProfileId id,
vabr (Chromium) 2015/10/06 12:51:21 Please remove "explicit", now that the c-tor has 2
Ed Baker 2015/10/06 16:07:44 Done.
+ base::nix::DesktopEnvironment desktop_env);
~NativeBackendKWallet() override;
@@ -150,6 +152,13 @@ class NativeBackendKWallet : public PasswordStoreX::NativeBackend {
// The application name (e.g. "Chromium"), shown in KWallet auth dialogs.
const std::string app_name_;
+ // KWallet DBus name
+ std::string dbus_service_name_;
+ // DBus path to KWallet interfaces
+ std::string dbus_path_;
+ // The name used for logging and by klauncher when starting KWallet
+ std::string kwalletd_name_;
+
DISALLOW_COPY_AND_ASSIGN(NativeBackendKWallet);
};

Powered by Google App Engine
This is Rietveld 408576698