Use kwalletd5 in KDE 5 environments

Use kwalletd5 in KDE 5 environments

KWallet in KDE 5 has updated DBus and desktop names. By default the detected
desktop environment is used to configure KWallet. Alternatively, passing
kwallet5 or kwallet to --password-store will respectively set kwalletd5 or
kwalletd.

* Pass the desktop environment as a parameter to unit tests. Note that
  GetAllLoginsErrorHandling is unchanged, but grouped with the rest of
  NativeBackendKWalletTest cases.
* Error messages use kwalletd or kwalletd5.

BUG=500281
Committed: https://crrev.com/8917b83c677a8c632d5df666f72046f80c74472d
Cr-Commit-Position: refs/heads/master@{#352620}

[Ed Baker, 2015-10-05 18:21:10]

edward.baker@intel.com changed reviewers:
+ vabr@chromium.org

[Ed Baker, 2015-10-05 18:22:45]

@vabr: Follow up patch from our discussion on the KDE 5 desktop environment
submission. PTAL when you get a minute.

[vabr (Chromium), 2015-10-06 12:51:21]

This LGTM, thanks!
Vaclav

https://codereview.chromium.org/1383303002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/native_backend_kwallet_x.h (right):

https://codereview.chromium.org/1383303002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/native_backend_kwallet_x.h:38: explicit
NativeBackendKWallet(LocalProfileId id,
Please remove "explicit", now that the c-tor has 2 arguments.

https://codereview.chromium.org/1383303002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
(right):

https://codereview.chromium.org/1383303002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc:149:
explicit NativeBackendKWalletStub(LocalProfileId id,
Please also drop "explicit" here.

[Ed Baker, 2015-10-06 16:07:45]

https://codereview.chromium.org/1383303002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/native_backend_kwallet_x.h (right):

https://codereview.chromium.org/1383303002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/native_backend_kwallet_x.h:38: explicit
NativeBackendKWallet(LocalProfileId id,
On 2015/10/06 12:51:21, vabr (Chromium) wrote:
> Please remove "explicit", now that the c-tor has 2 arguments.

Done.

https://codereview.chromium.org/1383303002/diff/1/chrome/browser/password_man...
File chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
(right):

https://codereview.chromium.org/1383303002/diff/1/chrome/browser/password_man...
chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc:149:
explicit NativeBackendKWalletStub(LocalProfileId id,
On 2015/10/06 12:51:21, vabr (Chromium) wrote:
> Please also drop "explicit" here.

Done.

[vabr (Chromium), 2015-10-06 16:09:38]

LGTM, thanks!
Vaclav

[Ed Baker, 2015-10-06 16:10:25]

The CQ bit was checked by edward.baker@intel.com

[commit-bot: I haz the power, 2015-10-06 16:10:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1383303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1383303002/20001

[commit-bot: I haz the power, 2015-10-06 16:43:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-06 16:43:47]

Patchset 2 (id:??) landed as
https://crrev.com/8917b83c677a8c632d5df666f72046f80c74472d
Cr-Commit-Position: refs/heads/master@{#352620}