Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Issue 1383293002: Revert of Overlays: Remove special casing of primary overlay plane (Closed)

Created:
5 years, 2 months ago by ccameron
Modified:
5 years, 2 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, Andre
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Overlays: Remove special casing of primary overlay plane (patchset #5 id:80001 of https://codereview.chromium.org/1376883004/ ) Reason for revert: Speculative revert because this might be related to a browser crash rate uptick in crbug.com/539374. Original issue's description: > Overlays: Remove special casing of primary overlay plane > > Mac will soon want to skip drawing the primary overlay plane, which > now can be accomplished by having the overlay strategy simply not emit > it. > > BUG=533687 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/e532ed0710935ef66a860b08b8e2a1e36a426b27 > Cr-Commit-Position: refs/heads/master@{#352186} TBR=alexst@chromium.org,dnicoara@chromium.org,achaulk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=533687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -116 lines) Patch
M cc/output/direct_renderer.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/output_surface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/output/output_surface.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/output/overlay_strategy_common.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M cc/output/overlay_unittest.cc View 42 chunks +66 lines, -88 lines 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc View 2 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ccameron
5 years, 2 months ago (2015-10-05 17:47:19 UTC) #1
Created Revert of Overlays: Remove special casing of primary overlay plane

Powered by Google App Engine
This is Rietveld 408576698