Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1383123003: Revert of Fixed the audio backgrounding bug (Closed)

Created:
5 years, 2 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org, Georges Khalil
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixed the audio backgrounding bug (patchset #28 id:1220001 of https://codereview.chromium.org/1214883004/ ) Reason for revert: Speculative revert since we see failing tests in the WebRTC waterfall related to audio. See https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/21950 https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/43969 (after landing...) Looked more into the details but I don't think this CL is the cause. Sorry. Will let it run one round just in case and then revert the revert. Original issue's description: > Fixed the audio backgrounding bug. > > Fixed the fact that we don't background a tab that initially skipped backgrounding because audio was playing (at the moment the tab was hidden) when the audio stops. > > We now make calls to UpdateProcessPriority when audio starts or stops. > > BUG=491895 > > Committed: https://crrev.com/349188e9ed037b427815c9e5ad55223d043ab6fd > Cr-Commit-Position: refs/heads/master@{#352421} TBR=gab@chromium.org,dalecurtis@chromium.org,nick@chromium.org,miu@chromium.org,avi@chromium.org,rsesek@chromium.org,jam@chromium.org,sebsg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=491895 Committed: https://crrev.com/4148513e2c1d40f3206396f8fff62f23b870459b Cr-Commit-Position: refs/heads/master@{#352562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -363 lines) Patch
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 7 chunks +9 lines, -160 lines 0 comments Download
M chrome/test/data/extensions/loop_audio.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 2 chunks +1 line, -27 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 3 chunks +4 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 57 chunks +206 lines, -159 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
henrika (OOO until Aug 14)
Created Revert of Fixed the audio backgrounding bug
5 years, 2 months ago (2015-10-06 07:38:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383123003/1
5 years, 2 months ago (2015-10-06 07:39:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 07:40:31 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4148513e2c1d40f3206396f8fff62f23b870459b Cr-Commit-Position: refs/heads/master@{#352562}
5 years, 2 months ago (2015-10-06 07:41:08 UTC) #4
henrika (OOO until Aug 14)
I was wrong. Will revert the revert.
5 years, 2 months ago (2015-10-06 08:41:05 UTC) #5
henrika (OOO until Aug 14)
5 years, 2 months ago (2015-10-06 08:42:26 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1386103002/ by henrika@chromium.org.

The reason for reverting is: My assumption about that this CL caused WebRTC
tests to fail was invalid..

Powered by Google App Engine
This is Rietveld 408576698