Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1383093002: [bindings] support legacyiterable<> WebIDL syntax (Closed)

Created:
5 years, 2 months ago by caitp (gmail)
Modified:
5 years, 2 months ago
Reviewers:
haraken, Jens Widell, jsbell, phillipj
CC:
blink-reviews, asanka, benjhayden+dwatch_chromium.org, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[bindings] support legacyiterable<> WebIDL syntax Add basic support for legacyiterable<> in order to implement the iterable HTMLCollection. BUG=538558 LOG=N R=jsbell@chromium.org, phillipj@opera.com, jl@opera.com

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -13 lines) Patch
M third_party/WebKit/Source/bindings/scripts/idl_definitions.py View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 1 chunk +3 lines, -1 line 0 comments Download
A third_party/WebKit/Source/bindings/tests/idls/core/TestInterface4.idl View 1 chunk +17 lines, -0 lines 1 comment Download
A + third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface4.h View 3 chunks +12 lines, -12 lines 0 comments Download
A third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface4.cpp View 1 chunk +209 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
caitp (gmail)
PTAL when you get the chance. Adds the underlying WebIDL support needed to support iterable ...
5 years, 2 months ago (2015-10-03 16:57:15 UTC) #1
caitp (gmail)
On 2015/10/03 16:57:15, caitp wrote: > PTAL when you get the chance. Adds the underlying ...
5 years, 2 months ago (2015-10-03 16:59:54 UTC) #2
haraken
The implementation looks good. https://codereview.chromium.org/1383093002/diff/1/third_party/WebKit/Source/bindings/tests/idls/core/TestInterface4.idl File third_party/WebKit/Source/bindings/tests/idls/core/TestInterface4.idl (right): https://codereview.chromium.org/1383093002/diff/1/third_party/WebKit/Source/bindings/tests/idls/core/TestInterface4.idl#newcode16 third_party/WebKit/Source/bindings/tests/idls/core/TestInterface4.idl:16: [RuntimeEnabled=FeatureName] legacyiterable<any>; Can we add ...
5 years, 2 months ago (2015-10-04 03:04:17 UTC) #4
caitp (gmail)
5 years, 2 months ago (2015-10-04 12:27:45 UTC) #5
Message was sent while issue was closed.
On 2015/10/04 03:04:17, haraken wrote:
> The implementation looks good.
> 

There are  some making list  threads saying legacyiterable isn't really needed,
since you get the same behavior for integer length attribute + indexed property
getter. So, it's more invasive to implement that because there are more
interfaces like that, but maybe it's the right thing to do? I've started working
on an approach like that. Does that seem like a better approach?

>
https://codereview.chromium.org/1383093002/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/tests/idls/core/TestInterface4.idl
> (right):
> 
>
https://codereview.chromium.org/1383093002/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/tests/idls/core/TestInterface4.idl:16:
> [RuntimeEnabled=FeatureName] legacyiterable<any>;
> 
> Can we add this to any of existing test interface? (I just don't want to bloat
> the size of test result files.)

Powered by Google App Engine
This is Rietveld 408576698