Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again.

Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again.

Without that, it has a few false positives about out-of-bounds array accesses.
Also makes the clang static-analyzer happy.

Original code review from Sven Panne:
https://codereview.chromium.org/790723002/

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg

Committed: https://crrev.com/93ae81101af68d81b7af84ea4046ea849e605116
Cr-Commit-Position: refs/heads/master@{#31163}

[skomski, 2015-10-06 13:22:12]

karl@skomski.com changed reviewers:
+ bmeurer@chromium.org, jochen@chromium.org

[skomski, 2015-10-06 13:30:06]

PTAL
Sorry for the relands :( It is a bit wacky that the trybot v8_arm uses clang but
the v8 arm builder on tree uses gcc crosscompile. Is there a trybot with the
configuration from tree?

First fix:
patchset 2 - removing undefined behaviour (signed overflow) test that results
with noreturn in wrong code

Second fix:
https://codereview.chromium.org/1372133006/

[Benedikt Meurer, 2015-10-07 03:38:04]

lgtm

[skomski, 2015-10-07 06:50:31]

The CQ bit was checked by karl@skomski.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-07 06:50:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1383053005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1383053005/20001

[commit-bot: I haz the power, 2015-10-07 07:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-07 07:31:13]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2015-10-07 09:42:45]

lgtm

[skomski, 2015-10-07 18:16:17]

The CQ bit was checked by karl@skomski.com

[skomski, 2015-10-07 18:16:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1383053005/#ps40001
(title: "avoid gcc 4.8 compiler bug on arm by switching checks around")

[commit-bot: I haz the power, 2015-10-07 18:16:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1383053005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1383053005/40001

[commit-bot: I haz the power, 2015-10-07 18:58:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-07 18:58:54]

Patchset 3 (id:??) landed as
https://crrev.com/93ae81101af68d81b7af84ea4046ea849e605116
Cr-Commit-Position: refs/heads/master@{#31163}

[Benedikt Meurer, 2015-10-08 04:32:55]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1398643002/ by bmeurer@chromium.org.

The reason for reverting is: Breaks Arm debug..

[skomski, 2015-10-08 08:05:11]

On 2015/10/08 04:32:55, Benedikt Meurer wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1398643002/ by mailto:bmeurer@chromium.org.
> 
> The reason for reverting is: Breaks Arm debug..

Sorry but GCC 4.8 on arm is trolling me so bad:

The last CR worked fine on arm debug and only broke on arm release.
So I tested with arm release and could avoid the compiler bug by switching
the checks around but now it breaks on arm debug.