Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1383053002: Change from ::stdout to stderr when reporting fatal error. (Closed)

Created:
5 years, 2 months ago by Karl
Modified:
5 years, 2 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change from ::stdout to stderr when reporting fatal error. The pnacl linux x86_64 buildbot doesn't understand ::stdout (it uses a macro to define stdout). Fix by removing :: prefix. Also redirects the error messages to stderr instead of stdout. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4e6ea83aecbae8725af6f8498847ce4cbecbe33b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/IceCompileServer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Karl
5 years, 2 months ago (2015-10-02 19:36:28 UTC) #2
Jim Stichnoth
still lgtm :)
5 years, 2 months ago (2015-10-02 19:38:58 UTC) #3
Karl
5 years, 2 months ago (2015-10-02 19:42:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4e6ea83aecbae8725af6f8498847ce4cbecbe33b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698