Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 138303002: Add blink::WebWaitableEvent interface (blink side) (Closed)

Created:
6 years, 11 months ago by kinuko
Modified:
6 years, 11 months ago
CC:
blink-reviews, jamesr, kinuko+watch, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Add blink::WebWaitableEvent interface (blink side) chromium side: https://codereview.chromium.org/133493003/ BUG=334263 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165131

Patch Set 1 #

Patch Set 2 : WebVector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -19 lines) Patch
M Source/core/workers/WorkerThread.h View 3 chunks +11 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 3 chunks +6 lines, -0 lines 0 comments Download
M public/platform/Platform.h View 1 2 chunks +15 lines, -2 lines 0 comments Download
A + public/platform/WebWaitableEvent.h View 2 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
Simpler part. PTL
6 years, 11 months ago (2014-01-14 14:51:57 UTC) #1
jochen (gone - plz use gerrit)
why not a WebVector instead of a raw pointer array?
6 years, 11 months ago (2014-01-14 15:45:30 UTC) #2
kinuko
Updated to use WebVector.
6 years, 11 months ago (2014-01-14 17:01:02 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-14 20:06:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/138303002/70001
6 years, 11 months ago (2014-01-15 01:48:03 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 15:00:23 UTC) #6
Message was sent while issue was closed.
Change committed as 165131

Powered by Google App Engine
This is Rietveld 408576698