[css-grid] Fix definite/indefinite size detection for abspos elements

third_party/WebKit/Source/core/layout/LayoutBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 2381 matching lines @@
         return intrinsicContentHeight;
     }
     if (logicalHeightLength.isFillAvailable())
         return containingBlock()->availableLogicalHeight(ExcludeMarginBorderPadding) - borderAndPadding;
     ASSERT_NOT_REACHED();
     return 0;
 }
 
 LayoutUnit LayoutBox::computeContentAndScrollbarLogicalHeightUsing(SizeType heightType, const Length& height, LayoutUnit intrinsicContentHeight) const
 {
+    if (isOutOfFlowPositioned() && height.isAuto() && !style()->logicalTop().isAuto() && !style()->logicalBottom().isAuto()) {
+        LogicalExtentComputedValues computedValues;
+        computeLogicalHeight(logicalHeight(), 0, computedValues);

[mstensho (USE GERRIT), 2015/10/02 09:08:50]

I don't think this is the right place to do this. Surely we already handle
correct height calculation when top and bottom are non-auto. Something else must
be wrong.

[cbiesinger, 2015/10/02 16:40:19]

Yes, this is handled in computePositionedLogicalHeight:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Why is this change needed here?

[Manuel Rego, 2016/04/08 07:53:14]

It seems this is not needed anymore, so I'm removing this change.

+        return computedValues.m_extent - borderAndPaddingLogicalHeight() - scrollbarLogicalHeight();
+    }
+
     if (height.isAuto())
         return heightType == MinSize ? 0 : -1;
     // FIXME(cbiesinger): The css-sizing spec is considering changing what min-content/max-content should resolve to.
     // If that happens, this code will have to change.
     if (height.isIntrinsic()) {
         if (intrinsicContentHeight == -1)
             return -1; // Intrinsic height isn't available.
         return computeIntrinsicLogicalContentHeightUsing(height, intrinsicContentHeight, borderAndPaddingLogicalHeight()) + scrollbarLogicalHeight();
     }
     if (height.isFixed())
@@ skipping 1844 matching lines @@
     const LayoutBox* box = &layoutBox;
     while (!box->isLayoutView() && !box->isOutOfFlowPositioned()
         && (box->style()->logicalWidth().isAuto() || box->isAnonymousBlock())
         && !box->hasOverrideContainingBlockLogicalWidth())
         box = box->containingBlock();
 
     if (box->style()->logicalWidth().isFixed())
         return true;
     if (box->isLayoutView())
         return true;
-    // The size of the containing block of an absolutely positioned element is always definite with respect to that
-    // element (http://dev.w3.org/csswg/css-sizing-3/#definite).
-    if (box->isOutOfFlowPositioned())
+    if (box->isOutOfFlowPositioned() && box->style()->logicalWidth().isAuto() && !box->style()->logicalLeft().isAuto() && !box->style()->logicalRight().isAuto())

[mstensho (USE GERRIT), 2015/10/02 09:08:50]

The box->style()->logicalWidth().isAuto() confuses me. Is it necessary? Sure, if
all three (width, left, right) are auto, we have an over-constrained situation,
but does it matter here?

[cbiesinger, 2015/10/02 16:40:19]

I too am skeptical that this is correct... do you have a concrete testcase that
this change fixes?

[Manuel Rego, 2016/04/08 07:53:14]

Yeah, we don't need to check if width is auto too, I've removed that condition.

         return true;
     if (box->hasOverrideContainingBlockLogicalWidth())
         return box->overrideContainingBlockContentLogicalWidth() != -1;
     if (box->style()->logicalWidth().hasPercent())
         return logicalWidthIsResolvable(*box->containingBlock());
 
     return false;
 }
 
 bool LayoutBox::hasDefiniteLogicalWidth() const
 {
     return logicalWidthIsResolvable(*this);
 }
 
 bool LayoutBox::percentageLogicalHeightIsResolvable() const
 {
     Length fakeLength(100, Percent);
     return computePercentageLogicalHeight(fakeLength) != -1;
 }
 
 bool LayoutBox::hasDefiniteLogicalHeight() const
 {
     const Length& logicalHeight = style()->logicalHeight();
-    if (logicalHeight.isIntrinsicOrAuto())
-        return false;
     if (logicalHeight.isFixed())
         return true;
-    // The size of the containing block of an absolutely positioned element is always definite with respect to that
-    // element (http://dev.w3.org/csswg/css-sizing-3/#definite).
-    if (isOutOfFlowPositioned())
+    if (isOutOfFlowPositioned() && logicalHeight.isAuto() && !style()->logicalTop().isAuto() && !style()->logicalBottom().isAuto())

[mstensho (USE GERRIT), 2015/10/02 09:08:50]

Same question as in logicalWidthIsResolvable().

[cbiesinger, 2015/10/02 16:40:19]

As I wrote in the other patch:
I don't believe that's a correct interpretation of the CSS spec. At least,
https://drafts.csswg.org/css-sizing-3/#definite does not indicate that this
would be a definite size?

[Manuel Rego, 2016/04/08 07:53:14]

Again I've removed here the condition to check if height is auto.

Tab confirmed that this is a definitive size:
https://lists.w3.org/Archives/Public/www-style/2015Nov/0074.html

         return true;
     if (hasOverrideContainingBlockLogicalHeight())
         return overrideContainingBlockContentLogicalHeight() != -1;
+    if (logicalHeight.isIntrinsicOrAuto())
+        return false;
 
     return percentageLogicalHeightIsResolvable();
 }
 
 bool LayoutBox::hasUnsplittableScrollingOverflow() const
 {
     // We will paginate as long as we don't scroll overflow in the pagination direction.
     bool isHorizontal = isHorizontalWritingMode();
     if ((isHorizontal && !scrollsOverflowY()) || (!isHorizontal && !scrollsOverflowX()))
         return false;
@@ skipping 442 matching lines @@
     StyleImage* borderImage = style()->borderImage().image();
     return borderImage && borderImage->canRender(*this, style()->effectiveZoom()) && borderImage->isLoaded();
 }
 
 ShapeOutsideInfo* LayoutBox::shapeOutsideInfo() const
 {
     return ShapeOutsideInfo::isEnabledFor(*this) ? ShapeOutsideInfo::info(*this) : nullptr;
 }
 
 } // namespace blink