Issue 1382993005: Don't run larger datagram tests on Mac OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1382993005: Don't run larger datagram tests on Mac OS (Closed)

Created:
5 years, 2 months ago by Søren Gjesse

Modified:
5 years, 2 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't run larger datagram tests on Mac OS These new tests fail on the default Mac OS configuration. TBR=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e0daf8dd9368d8260ded38d251e98e0c09a55c9a

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	tests/standalone/io/raw_datagram_socket_test.dart	View		1 chunk	+6 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #1 (id:1) manually as e0daf8dd9368d8260ded38d251e98e0c09a55c9a (presubmit successful).

5 years, 2 months ago (2015-10-06 08:21:04 UTC) #2

kustermann

LGTM https://codereview.chromium.org/1382993005/diff/1/tests/standalone/io/raw_datagram_socket_test.dart File tests/standalone/io/raw_datagram_socket_test.dart (right): https://codereview.chromium.org/1382993005/diff/1/tests/standalone/io/raw_datagram_socket_test.dart#newcode325 tests/standalone/io/raw_datagram_socket_test.dart:325: if (!Platform.isMacOS) { Maybe add a comment about ...

5 years, 2 months ago (2015-10-06 08:21:29 UTC) #3

Søren Gjesse

5 years, 2 months ago (2015-10-06 08:22:49 UTC) #4

Message was sent while issue was closed.

On 2015/10/06 08:21:29, kustermann wrote:
> LGTM
> 
>
https://codereview.chromium.org/1382993005/diff/1/tests/standalone/io/raw_dat...
> File tests/standalone/io/raw_datagram_socket_test.dart (right):
> 
>
https://codereview.chromium.org/1382993005/diff/1/tests/standalone/io/raw_dat...
> tests/standalone/io/raw_datagram_socket_test.dart:325: if (!Platform.isMacOS)
{
> Maybe add a comment about why they fail (I assume default MTU is lower)?

Will do - I just wanted the tree green.

Expand Messages | Collapse Messages