Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1382943004: Some iOS fixes to make SampleApp work better. (Closed)

Created:
5 years, 2 months ago by jvanverth1
Modified:
5 years, 2 months ago
Reviewers:
bsalomon, caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Some iOS fixes to make SampleApp work better. Changes: - Rebuild argc and argv so we can process command line arguments - Remove unnecessary SimpleiOSApp files - Add support for reading files from the app bundle - Add gpu flag so we can start up directly into OpenGL Committed: https://skia.googlesource.com/skia/+/44dcb8a84bcced3a42609ecb4abac1f3e7cc6cbe

Patch Set 1 #

Patch Set 2 : Remove unnecessary xib files from project #

Patch Set 3 : Some clean up #

Patch Set 4 : Fix MSVC build #

Patch Set 5 : Add missing comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -13 lines) Patch
M experimental/iOSSampleApp/SkSampleUIView.mm View 1 2 1 chunk +17 lines, -2 lines 0 comments Download
M gyp/SampleApp.gyp View 1 2 3 4 4 chunks +20 lines, -9 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/ports/SkOSFile_stdio.cpp View 2 chunks +42 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jvanverth1
5 years, 2 months ago (2015-10-02 15:08:47 UTC) #2
bsalomon
lgtm
5 years, 2 months ago (2015-10-02 15:12:38 UTC) #3
reed1
lgtm
5 years, 2 months ago (2015-10-02 15:31:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382943004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382943004/40001
5 years, 2 months ago (2015-10-02 15:35:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/3521) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 2 months ago (2015-10-02 15:37:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382943004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382943004/80001
5 years, 2 months ago (2015-10-02 16:05:38 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 16:12:08 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/44dcb8a84bcced3a42609ecb4abac1f3e7cc6cbe

Powered by Google App Engine
This is Rietveld 408576698