Add a Submit method to the keyboard interface

Keyboard support for a submit button and setting the IME's text content and selection

* Add a KeyboardClient.Submit callback invoked when the submit key is pressed in the IME
* KeyboardService.SetText and SetSelection can be used to update the IME's state to match the contents of an edit widget
* Also copy InputConnectionAdaptor.sendKeyEvent to keep the Mojo version of InputConnectionAdaptor in sync with Sky's version

R=abarth@chromium.org, jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/1292152bf533de1bfebf5966d6246e149f87add3

[jsimmons1, 2015-10-01 20:19:18]

jsimmons@google.com changed reviewers:
+ abarth@chromium.org

[jsimmons1, 2015-10-06 19:44:10]

jsimmons@google.com changed reviewers:
+ jamesr@chromium.org

[abarth-chromium, 2015-10-06 21:52:20]

lgtm

https://codereview.chromium.org/1382943003/diff/20001/services/keyboard/src/o...
File
services/keyboard/src/org/chromium/mojo/keyboard/InputConnectionAdaptor.java
(right):

https://codereview.chromium.org/1382943003/diff/20001/services/keyboard/src/o...
services/keyboard/src/org/chromium/mojo/keyboard/InputConnectionAdaptor.java:98:
mClient.submit();
Should we pass through the action code?

[jsimmons1, 2015-10-06 22:12:04]

https://codereview.chromium.org/1382943003/diff/20001/services/keyboard/src/o...
File
services/keyboard/src/org/chromium/mojo/keyboard/InputConnectionAdaptor.java
(right):

https://codereview.chromium.org/1382943003/diff/20001/services/keyboard/src/o...
services/keyboard/src/org/chromium/mojo/keyboard/InputConnectionAdaptor.java:98:
mClient.submit();
On 2015/10/06 21:52:20, abarth-chromium wrote:
> Should we pass through the action code?

Added an argument to the Mojo interface.  For now, the Android adapter only
supports one action ("done")

[jamesr, 2015-10-07 01:04:42]

lgtm

https://codereview.chromium.org/1382943003/diff/40001/services/keyboard/src/o...
File
services/keyboard/src/org/chromium/mojo/keyboard/InputConnectionAdaptor.java
(right):

https://codereview.chromium.org/1382943003/diff/40001/services/keyboard/src/o...
services/keyboard/src/org/chromium/mojo/keyboard/InputConnectionAdaptor.java:87:
// Number keys come through as key events instead of commitText!?
who's the intended user of this comment?

[jsimmons1, 2015-10-07 01:14:14]

https://codereview.chromium.org/1382943003/diff/40001/services/keyboard/src/o...
File
services/keyboard/src/org/chromium/mojo/keyboard/InputConnectionAdaptor.java
(right):

https://codereview.chromium.org/1382943003/diff/40001/services/keyboard/src/o...
services/keyboard/src/org/chromium/mojo/keyboard/InputConnectionAdaptor.java:87:
// Number keys come through as key events instead of commitText!?
On 2015/10/07 01:04:42, jamesr wrote:
> who's the intended user of this comment?

I'm not sure - this was pre-existing code copied over from the Sky repository.

I think this was a note from eseidel@ saying that keys from the Android numeric
keypad are reported via calls to sendKeyEvent, whereas other text entry shows up
in calls to commitText.

[jsimmons1, 2015-10-13 17:59:52]

Committed patchset #3 (id:40001) manually as
1292152bf533de1bfebf5966d6246e149f87add3 (presubmit successful).