Issue 1382933002: Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1382933002: Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (Closed)

Created:
5 years, 2 months ago by joshualitt

Modified:
5 years, 2 months ago

Reviewers:
dogben, borenet

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@bl-nanobench

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 (patchset #1 id:1 of https://codereview.chromium.org/1365683003/ ) Reason for revert: should hopefully be fixed, please reland if not. Original issue's description: > Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373 > > BUG=skia:4373 > > Committed: https://skia.googlesource.com/skia/+/3420d2796bad5ce553efb9909790ea72e578dc47 TBR=borenet@google.com,benjaminwagner@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4373 Committed: https://skia.googlesource.com/skia/+/52f8deba607fd67558b57551cd43406c8b743072

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	tools/nanobench_flags.json	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	tools/nanobench_flags.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

joshualitt

Created Revert of Blacklist GLVertexAttributesBench and GLVec4ScalarBench for GalaxyS4 due to skia:4373

5 years, 2 months ago (2015-10-01 19:08:57 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382933002/1

5 years, 2 months ago (2015-10-01 19:09:12 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/52f8deba607fd67558b57551cd43406c8b743072

5 years, 2 months ago (2015-10-01 19:09:20 UTC) #3

dogben

5 years, 2 months ago (2015-10-01 23:25:40 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1375733003/ by benjaminwagner@google.com.

The reason for reverting is: Not fixed. :-(.

Expand Messages | Collapse Messages