Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Side by Side Diff: src/hydrogen-instructions.h

Issue 13829009: MathSqrt and MathPowHalf do not cause any promotion. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2591 matching lines...) Expand 10 before | Expand all | Expand 10 after
2602 SetOperandAt(1, value); 2602 SetOperandAt(1, value);
2603 switch (op) { 2603 switch (op) {
2604 case kMathFloor: 2604 case kMathFloor:
2605 case kMathRound: 2605 case kMathRound:
2606 case kMathCeil: 2606 case kMathCeil:
2607 set_representation(Representation::Integer32()); 2607 set_representation(Representation::Integer32());
2608 break; 2608 break;
2609 case kMathAbs: 2609 case kMathAbs:
2610 // Not setting representation here: it is None intentionally. 2610 // Not setting representation here: it is None intentionally.
2611 SetFlag(kFlexibleRepresentation); 2611 SetFlag(kFlexibleRepresentation);
2612 // TODO(svenpanne) This flag is actually only needed if representation()
2613 // is tagged, and not when it is an unboxed double or unboxed integer.
2612 SetGVNFlag(kChangesNewSpacePromotion); 2614 SetGVNFlag(kChangesNewSpacePromotion);
2613 break; 2615 break;
2614 case kMathSqrt:
2615 case kMathPowHalf:
2616 case kMathLog: 2616 case kMathLog:
2617 case kMathSin: 2617 case kMathSin:
2618 case kMathCos: 2618 case kMathCos:
2619 case kMathTan: 2619 case kMathTan:
2620 set_representation(Representation::Double()); 2620 set_representation(Representation::Double());
2621 // These operations use the TranscendentalCache, so they may allocate.
2621 SetGVNFlag(kChangesNewSpacePromotion); 2622 SetGVNFlag(kChangesNewSpacePromotion);
2622 break; 2623 break;
2623 case kMathExp: 2624 case kMathExp:
2625 case kMathSqrt:
2626 case kMathPowHalf:
2624 set_representation(Representation::Double()); 2627 set_representation(Representation::Double());
2625 break; 2628 break;
2626 default: 2629 default:
2627 UNREACHABLE(); 2630 UNREACHABLE();
2628 } 2631 }
2629 SetFlag(kUseGVN); 2632 SetFlag(kUseGVN);
2630 } 2633 }
2631 2634
2632 virtual bool IsDeletable() const { return true; } 2635 virtual bool IsDeletable() const { return true; }
2633 2636
(...skipping 3910 matching lines...) Expand 10 before | Expand all | Expand 10 after
6544 virtual bool IsDeletable() const { return true; } 6547 virtual bool IsDeletable() const { return true; }
6545 }; 6548 };
6546 6549
6547 6550
6548 #undef DECLARE_INSTRUCTION 6551 #undef DECLARE_INSTRUCTION
6549 #undef DECLARE_CONCRETE_INSTRUCTION 6552 #undef DECLARE_CONCRETE_INSTRUCTION
6550 6553
6551 } } // namespace v8::internal 6554 } } // namespace v8::internal
6552 6555
6553 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6556 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698