third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp - Issue 1382883002: Fixing performance issue of creating imagebitmap from ImageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp

Issue 1382883002: Fixing performance issue of creating imagebitmap from ImageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove the benchmark test which has been landed already Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/GraphicsTypes.h ('K') | « third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp b/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp

index f01b7a7c7a05ab75ca9b3ab42603c815cefebff0..0dac45b7c250c996aea3df9a364e5f7a4fade1f3 100644

--- a/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp

+++ b/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp

@@ -38,7 +38,7 @@

namespace blink {

-UnacceleratedImageBufferSurface::UnacceleratedImageBufferSurface(const IntSize& size, OpacityMode opacityMode)

+UnacceleratedImageBufferSurface::UnacceleratedImageBufferSurface(const IntSize& size, OpacityMode opacityMode, ImageBitmapSourceType sourceType)

: ImageBufferSurface(size, opacityMode)

{

SkAlphaType alphaType = (Opaque == opacityMode) ? kOpaque_SkAlphaType : kPremul_SkAlphaType;

@@ -46,8 +46,10 @@ UnacceleratedImageBufferSurface::UnacceleratedImageBufferSurface(const IntSize&

SkSurfaceProps disableLCDProps(0, kUnknown_SkPixelGeometry);

m_surface = adoptRef(SkSurface::NewRaster(info, Opaque == opacityMode ? 0 : &disableLCDProps));

- if (m_surface)

- clear();

+ if (sourceType == NotFromImageData) {

+ if (m_surface)

+ clear();

+ }

}

UnacceleratedImageBufferSurface::~UnacceleratedImageBufferSurface() { }