third_party/WebKit/Source/core/frame/ImageBitmap.cpp - Issue 1382883002: Fixing performance issue of creating imagebitmap from ImageData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Issue 1382883002: Fixing performance issue of creating imagebitmap from ImageData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | third_party/WebKit/Source/platform/graphics/UnacceleratedSimpleImageBufferSurface.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

index 62388bc0fb578bd02059e4556ea598892a587f45..f07d175c2d6b0b1c3ce2dd5d80f1c0ed9899890c 100644

--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp

@@ -98,7 +98,9 @@ ImageBitmap::ImageBitmap(ImageData* data, const IntRect& cropRect)

, m_bitmapOffset(IntPoint())

{

IntRect srcRect = intersection(cropRect, IntRect(IntPoint(), data->size()));

- OwnPtr<ImageBuffer> buffer = ImageBuffer::create(data->size());

+ OpacityMode opacityMode = Opaque;

+ OwnPtr<ImageBuffer> buffer = ImageBuffer::createSimple(data->size(), opacityMode);

if (!buffer)

return;