Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1382873003: win_toolchain: Update packaging script to package win10 sdk (Closed)

Created:
5 years, 2 months ago by scottmg
Modified:
5 years, 2 months ago
Reviewers:
brucedawson
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

win_toolchain: Update packaging script to package win10 sdk R=brucedawson@chromium.org BUG=491424 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297019

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -511 lines) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 2 3 2 chunks +9 lines, -4 lines 0 comments Download
M win_toolchain/package_from_installed.py View 1 6 chunks +19 lines, -13 lines 0 comments Download
D win_toolchain/toolchain2013.py View 1 chunk +0 lines, -494 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
https://codereview.chromium.org/1382873003/diff/1/win_toolchain/toolchain2013.py File win_toolchain/toolchain2013.py (left): https://codereview.chromium.org/1382873003/diff/1/win_toolchain/toolchain2013.py#oldcode1 win_toolchain/toolchain2013.py:1: #!/usr/bin/env python This used to pull together a toolchain ...
5 years, 2 months ago (2015-10-03 05:04:25 UTC) #1
brucedawson
One optional comment, but lgtm. https://codereview.chromium.org/1382873003/diff/40001/win_toolchain/get_toolchain_if_necessary.py File win_toolchain/get_toolchain_if_necessary.py (right): https://codereview.chromium.org/1382873003/diff/40001/win_toolchain/get_toolchain_if_necessary.py#newcode275 win_toolchain/get_toolchain_if_necessary.py:275: 'http://www.chromium.org/developers/how-tos/' You should change ...
5 years, 2 months ago (2015-10-05 20:07:05 UTC) #2
scottmg
Thanks https://codereview.chromium.org/1382873003/diff/40001/win_toolchain/get_toolchain_if_necessary.py File win_toolchain/get_toolchain_if_necessary.py (right): https://codereview.chromium.org/1382873003/diff/40001/win_toolchain/get_toolchain_if_necessary.py#newcode275 win_toolchain/get_toolchain_if_necessary.py:275: 'http://www.chromium.org/developers/how-tos/' On 2015/10/05 20:07:05, brucedawson wrote: > You ...
5 years, 2 months ago (2015-10-05 20:42:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382873003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382873003/60001
5 years, 2 months ago (2015-10-05 20:43:19 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 20:47:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297019

Powered by Google App Engine
This is Rietveld 408576698