Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1382863003:
Remove unused dsf related method (Closed)
|
Created:
5 years, 2 months ago by oshima Modified:
5 years, 2 months ago CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, blink-reviews-api_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove unused dsf related method
BUG=485650
Committed: https://crrev.com/72e31567bbd1672142b93e6070eb6e34caf31d37
Cr-Commit-Position: refs/heads/master@{#352267}
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 34 (15 generated)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382863003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382863003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382863003/40001
oshima@chromium.org changed reviewers: + eae@chromium.org
One step to remove dsf stuff from blink.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
LGTM
The CQ bit was checked by eae@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382863003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
oshima@chromium.org changed reviewers: + piman@chromium.org, rbyers@chromium.org
requesting owners review. piman@ -> content/ rbyers@ -> third_party/Webkit/public/
public/ LGTM
oshima@chromium.org changed reviewers: + avi@chromium.org
piman@ seems to be OOO avi@, can you review content/ ?
lgtm Looking good.
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382863003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382863003/40001
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/72e31567bbd1672142b93e6070eb6e34caf31d37 Cr-Commit-Position: refs/heads/master@{#352267} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
