Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1382853002: Remove trailing slash in codereview.settings to fix review url double slash (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove trailing slash in codereview.settings to fix review url double slash BUG= R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/c5aeb5a808388d0b128a812db087c6003d5839c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M codereview.settings View 1 chunk +1 line, -1 line 0 comments Download
M runtime/codereview.settings View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 2 months ago (2015-10-01 14:20:57 UTC) #2
ricow1
lgtm
5 years, 2 months ago (2015-10-01 14:26:06 UTC) #3
Cutch
5 years, 2 months ago (2015-10-01 14:27:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c5aeb5a808388d0b128a812db087c6003d5839c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698