Second part of moving V8 Binding Integrity off of vtables.

Second part of moving V8 Binding Integrity off of vtables.

Implements the wrappertypeinfo in scriptwrappable technique, but
does not perform the binding integrity check.

BUG=226633
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148737

[Tom Sepez, 2013-04-11 22:54:39]

Adam, please review (in your infinite spare time).

[abarth-chromium, 2013-04-11 22:59:33]

This patch is much easier to read now.  One style nit.  Haraken should do the
official review.

https://codereview.chromium.org/13828008/diff/3001/Source/bindings/scripts/Co...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/13828008/diff/3001/Source/bindings/scripts/Co...
Source/bindings/scripts/CodeGeneratorV8.pm:2862: void
scriptwrappable_init(${interfaceName}* object)
scriptwrappable_init <-- That's an odd name.

https://codereview.chromium.org/13828008/diff/3001/Source/bindings/v8/ScriptW...
File Source/bindings/v8/ScriptWrappable.h (right):

https://codereview.chromium.org/13828008/diff/3001/Source/bindings/v8/ScriptW...
Source/bindings/v8/ScriptWrappable.h:52: extern void scriptwrappable_init(C*);
// Workaround for lack of extern template prior to C++11.
Why do we need to extern for this function?  I guess we don't want to include
every header in the universe.

[Tom Sepez, 2013-04-11 23:02:35]

On 2013/04/11 22:59:33, abarth wrote:
> This patch is much easier to read now.  One style nit.  Haraken should do the
> official review.
> 
>
https://codereview.chromium.org/13828008/diff/3001/Source/bindings/scripts/Co...
> File Source/bindings/scripts/CodeGeneratorV8.pm (right):
> 
>
https://codereview.chromium.org/13828008/diff/3001/Source/bindings/scripts/Co...
> Source/bindings/scripts/CodeGeneratorV8.pm:2862: void
> scriptwrappable_init(${interfaceName}* object)
> scriptwrappable_init <-- That's an odd name.
> 
>
https://codereview.chromium.org/13828008/diff/3001/Source/bindings/v8/ScriptW...
> File Source/bindings/v8/ScriptWrappable.h (right):
> 
>
https://codereview.chromium.org/13828008/diff/3001/Source/bindings/v8/ScriptW...
> Source/bindings/v8/ScriptWrappable.h:52: extern void scriptwrappable_init(C*);
> // Workaround for lack of extern template prior to C++11.
> Why do we need to extern for this function?  I guess we don't want to include
> every header in the universe.

Exactly.  I've avoided the need for a centralized header of everything.

[haraken, 2013-04-12 01:01:11]

LGTM.

I'm pretty sure the patch is OK, but would you check performance of
Bindings/first-child.html just in case?

[Tom Sepez, 2013-04-12 17:58:19]

Looks like I introduced another branch. -7% on first-child. Let me try to get
rid of it.

[Tom Sepez, 2013-04-12 21:03:15]

Patch set 4 is avoids the branch, no performance penalty.

[abarth-chromium, 2013-04-12 21:08:13]

https://codereview.chromium.org/13828008/diff/13001/Source/bindings/v8/Script...
File Source/bindings/v8/ScriptWrappable.h (right):

https://codereview.chromium.org/13828008/diff/13001/Source/bindings/v8/Script...
Source/bindings/v8/ScriptWrappable.h:69: return;
four-space indent pls

[Tom Sepez, 2013-04-12 21:10:21]

On 2013/04/12 21:08:13, abarth wrote:
>
https://codereview.chromium.org/13828008/diff/13001/Source/bindings/v8/Script...
> File Source/bindings/v8/ScriptWrappable.h (right):
> 
>
https://codereview.chromium.org/13828008/diff/13001/Source/bindings/v8/Script...
> Source/bindings/v8/ScriptWrappable.h:69: return;
> four-space indent pls
Done.

[abarth-chromium, 2013-04-12 21:12:38]

I looked over the patch, and it looks reasonable to me, but I haven't looked in
enough detail to give it an official stamp.  You can probably land it with
haraken's earlier stamp if you wanted.

[haraken1, 2013-04-14 15:26:37]

LGTM, given no performance penalty in Bindings/first-child.html.

[commit-bot: I haz the power, 2013-04-19 17:10:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/13828008/52002

[commit-bot: I haz the power, 2013-04-19 17:40:01]

Change committed as 148737