Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/usb/web_usb_permission_provider.cc

Issue 1382783002: Store USB device permissions in website settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More chooser, less permission. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/usb/web_usb_permission_provider.cc
diff --git a/chrome/browser/usb/web_usb_permission_provider.cc b/chrome/browser/usb/web_usb_permission_provider.cc
index 8c31af4644a1ed1f66327fddda37aa2d201a33c5..080f22d0ea5598b95562083f5338c4bd755e8cb2 100644
--- a/chrome/browser/usb/web_usb_permission_provider.cc
+++ b/chrome/browser/usb/web_usb_permission_provider.cc
@@ -6,6 +6,8 @@
#include "base/command_line.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/usb/usb_chooser_context.h"
+#include "chrome/browser/usb/usb_chooser_context_factory.h"
#include "chrome/common/chrome_switches.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_frame_host.h"
@@ -92,14 +94,23 @@ void WebUSBPermissionProvider::HasDevicePermission(
mojo::Array<device::usb::DeviceInfoPtr> requested_devices,
const HasDevicePermissionCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- GURL origin = render_frame_host_->GetLastCommittedURL().GetOrigin();
+ GURL embedding_origin =
+ web_contents()->GetMainFrame()->GetLastCommittedURL().GetOrigin();
+ GURL requesting_origin =
+ render_frame_host_->GetLastCommittedURL().GetOrigin();
+ Profile* profile =
+ Profile::FromBrowserContext(web_contents()->GetBrowserContext());
+ UsbChooserContext* chooser_context =
+ UsbChooserContextFactory::GetForProfile(profile);
mojo::Array<mojo::String> allowed_guids(0);
for (size_t i = 0; i < requested_devices.size(); ++i) {
const device::usb::DeviceInfoPtr& device = requested_devices[i];
- if (FindOriginInDescriptorSet(device->webusb_allowed_origins.get(), origin,
- nullptr, nullptr) &&
- EnableWebUsbOnAnyOrigin())
+ if (FindOriginInDescriptorSet(device->webusb_allowed_origins.get(),
+ requesting_origin, nullptr, nullptr) &&
+ (EnableWebUsbOnAnyOrigin() ||
+ chooser_context->HasDevicePermission(requesting_origin,
+ embedding_origin, device->guid)))
allowed_guids.push_back(device->guid);
}
callback.Run(allowed_guids.Pass());

Powered by Google App Engine
This is Rietveld 408576698