chrome/browser/usb/usb_permission_context.h - Issue 1382783002: Store USB device permissions in website settings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/usb/usb_permission_context.h

Issue 1382783002: Store USB device permissions in website settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Split permission contexts from chooser permission contexts. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_USB_USB_PERMISSION_CONTEXT_H_

	6 #define CHROME_BROWSER_USB_USB_PERMISSION_CONTEXT_H_

	7

	8 #include "chrome/browser/permissions/permission_context_base.h"

	9

	10 class UsbPermissionContext : public PermissionContextBase {
	raymes 2015/10/07 04:48:29 Again, this would only be a permission that is que Again, this would only be a permission that is queryable, not requestable, etc. From my perspective that is completely ok and a good thing. The durable storage permission has some similarities. We would want to make this clear in the code though (e.g. RequestPermission should hit a NOTREACHED() or something). Mounir: what are your thoughts?
	11 public:

	12 explicit UsbPermissionContext(Profile* profile);

	13 ~UsbPermissionContext() override;

	14

	15 bool IsRestrictedToSecureOrigins() const override;

	16

	17 private:

	18 DISALLOW_COPY_AND_ASSIGN(UsbPermissionContext);

	19 };

	20

	21 #endif // CHROME_BROWSER_USB_USB_PERMISSION_CONTEXT_H_

OLD	NEW