sync/sessions/model_type_registry.cc - Issue 1382743004: [Sync] Move ModelTypeProcessor* and rename *Impl to Shared*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/sessions/model_type_registry.cc

Issue 1382743004: [Sync] Move ModelTypeProcessor* and rename *Impl to Shared*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: also the test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/internal_api/public/shared_model_type_processor.h ('K') | « sync/internal_api/sync_context_proxy_impl_unittest.cc ('k') | sync/sessions/model_type_registry_unittest.cc » ('j') | sync/test/engine/injectable_sync_context_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/sessions/model_type_registry.cc

diff --git a/sync/sessions/model_type_registry.cc b/sync/sessions/model_type_registry.cc

index 9c1609a61c6cc45c1daef2f2764a4b221d08ae91..b38f77d5f55d2a4a473527b9dfd49f0a88d00099 100644

--- a/sync/sessions/model_type_registry.cc

+++ b/sync/sessions/model_type_registry.cc

@@ -10,10 +10,10 @@

#include "sync/engine/commit_queue.h"

#include "sync/engine/directory_commit_contributor.h"

#include "sync/engine/directory_update_handler.h"

-#include "sync/engine/model_type_processor.h"

-#include "sync/engine/model_type_processor_impl.h"

#include "sync/engine/model_type_worker.h"

#include "sync/internal_api/public/activation_context.h"

+#include "sync/internal_api/public/model_type_processor.h"

+#include "sync/internal_api/public/shared_model_type_processor.h"

stanisc 2015/10/05 18:11:35 Why does ModelTypeRegistry need to know about Shar

maxbogue 2015/10/08 17:59:56 Turns out it doesn't! Fixed.

#include "sync/sessions/directory_type_debug_info_emitter.h"

#include "sync/util/cryptographer.h"