Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: components/sync_driver/non_blocking_data_type_controller.h

Issue 1382743004: [Sync] Move ModelTypeProcessor* and rename *Impl to Shared*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: also the test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/non_blocking_data_type_controller.h
diff --git a/components/sync_driver/non_blocking_data_type_controller.h b/components/sync_driver/non_blocking_data_type_controller.h
index 5faa79f1c07c6d378f1b36015159d02f9e9e3193..856aa6f7cb462d1868bfcdc562d5408a8051cfe7 100644
--- a/components/sync_driver/non_blocking_data_type_controller.h
+++ b/components/sync_driver/non_blocking_data_type_controller.h
@@ -12,7 +12,7 @@
#include "sync/internal_api/public/sync_context_proxy.h"
namespace syncer_v2 {
-class ModelTypeProcessorImpl;
+class SharedModelTypeProcessor;
}
namespace sync_driver_v2 {
@@ -63,7 +63,7 @@ class NonBlockingDataTypeController {
// will only ever deal with a single type proxy.
void InitializeType(
const scoped_refptr<base::SequencedTaskRunner>& task_runner,
- const base::WeakPtr<syncer_v2::ModelTypeProcessorImpl>& type_processor);
+ const base::WeakPtr<syncer_v2::SharedModelTypeProcessor>& type_processor);
// Initialize the connection to the SyncContextProxy.
//
@@ -87,19 +87,19 @@ class NonBlockingDataTypeController {
// Figures out which signals need to be sent then send then sends them.
void UpdateState();
- // Sends an enable signal to the ModelTypeProcessorImpl.
+ // Sends an enable signal to the SharedModelTypeProcessor.
void SendEnableSignal();
- // Sends a disable signal to the ModelTypeProcessorImpl.
+ // Sends a disable signal to the SharedModelTypeProcessor.
void SendDisableSignal();
- // Sends a disconnect signal to the ModelTypeProcessorImpl.
+ // Sends a disconnect signal to the SharedModelTypeProcessor.
void SendDisconnectSignal();
// Returns true if this type should be synced.
bool IsPreferred() const;
- // Returns true if this object has access to the ModelTypeProcessorImpl.
+ // Returns true if this object has access to the SharedModelTypeProcessor.
bool IsSyncProxyConnected() const;
// Returns true if this object has access to the SyncContextProxy.
@@ -123,9 +123,9 @@ class NonBlockingDataTypeController {
// Whether or not the user wants to sync this type.
bool is_preferred_;
- // The ModelTypeProcessorImpl and its associated thread. May be NULL.
+ // The SharedModelTypeProcessor and its associated thread. May be NULL.
scoped_refptr<base::SequencedTaskRunner> task_runner_;
- base::WeakPtr<syncer_v2::ModelTypeProcessorImpl> type_processor_;
+ base::WeakPtr<syncer_v2::SharedModelTypeProcessor> type_processor_;
stanisc 2015/10/05 18:11:35 This isn't how it should be, but it is OK for now
maxbogue 2015/10/08 17:59:56 Acknowledged.
// The SyncContextProxy that connects to the current sync backend. May be
// NULL.

Powered by Google App Engine
This is Rietveld 408576698