[Sync] Move ModelTypeProcessor* and rename *Impl to Shared*.

[Sync] Move ModelTypeProcessor* and rename *Impl to Shared*.

BUG=536895
Committed: https://crrev.com/786b459e828e3d593d92ccd8f1b53dee26cbe052
Cr-Commit-Position: refs/heads/master@{#353323}

[maxbogue, 2015-10-04 22:55:09]

maxbogue@chromium.org changed reviewers:
+ stanisc@chromium.org

[maxbogue, 2015-10-04 22:55:10]

Stan, PTAL!

[stanisc, 2015-10-05 18:11:35]

I have a few comments for now. I'll do a more detailed review once you've merged
with my changes.

https://codereview.chromium.org/1382743004/diff/40001/components/sync_driver/...
File components/sync_driver/non_blocking_data_type_controller.h (right):

https://codereview.chromium.org/1382743004/diff/40001/components/sync_driver/...
components/sync_driver/non_blocking_data_type_controller.h:128:
base::WeakPtr<syncer_v2::SharedModelTypeProcessor> type_processor_;
This isn't how it should be, but it is OK for now since you are simply renaming
the class.

https://codereview.chromium.org/1382743004/diff/40001/sync/internal_api/publi...
File sync/internal_api/public/shared_model_type_processor.h (right):

https://codereview.chromium.org/1382743004/diff/40001/sync/internal_api/publi...
sync/internal_api/public/shared_model_type_processor.h:26: class
SYNC_EXPORT_PRIVATE SharedModelTypeProcessor : public ModelTypeProcessor,
Why this class has to be in internal_api and not in sync_driver/components?

https://codereview.chromium.org/1382743004/diff/40001/sync/sessions/model_typ...
File sync/sessions/model_type_registry.cc (right):

https://codereview.chromium.org/1382743004/diff/40001/sync/sessions/model_typ...
sync/sessions/model_type_registry.cc:16: #include
"sync/internal_api/public/shared_model_type_processor.h"
Why does ModelTypeRegistry need to know about SharedModelTypeProcessor?

https://codereview.chromium.org/1382743004/diff/40001/sync/test/engine/inject...
File sync/test/engine/injectable_sync_context_proxy.cc (right):

https://codereview.chromium.org/1382743004/diff/40001/sync/test/engine/inject...
sync/test/engine/injectable_sync_context_proxy.cc:9: #include
"sync/internal_api/public/shared_model_type_processor.h"
This class will be deleted in my change.

[maxbogue, 2015-10-08 17:59:56]

PTAL! The merge with your change is complete.

https://codereview.chromium.org/1382743004/diff/40001/components/sync_driver/...
File components/sync_driver/non_blocking_data_type_controller.h (right):

https://codereview.chromium.org/1382743004/diff/40001/components/sync_driver/...
components/sync_driver/non_blocking_data_type_controller.h:128:
base::WeakPtr<syncer_v2::SharedModelTypeProcessor> type_processor_;
On 2015/10/05 18:11:35, stanisc wrote:
> This isn't how it should be, but it is OK for now since you are simply
renaming
> the class.

Acknowledged.

https://codereview.chromium.org/1382743004/diff/40001/sync/internal_api/publi...
File sync/internal_api/public/shared_model_type_processor.h (right):

https://codereview.chromium.org/1382743004/diff/40001/sync/internal_api/publi...
sync/internal_api/public/shared_model_type_processor.h:26: class
SYNC_EXPORT_PRIVATE SharedModelTypeProcessor : public ModelTypeProcessor,
On 2015/10/05 18:11:35, stanisc wrote:
> Why this class has to be in internal_api and not in sync_driver/components?

Because it CAN be, and //sync has less deps than //components/sync_driver.
Generally speaking, things should always live as far up the dependency chain as
possible.

https://codereview.chromium.org/1382743004/diff/40001/sync/sessions/model_typ...
File sync/sessions/model_type_registry.cc (right):

https://codereview.chromium.org/1382743004/diff/40001/sync/sessions/model_typ...
sync/sessions/model_type_registry.cc:16: #include
"sync/internal_api/public/shared_model_type_processor.h"
On 2015/10/05 18:11:35, stanisc wrote:
> Why does ModelTypeRegistry need to know about SharedModelTypeProcessor?

Turns out it doesn't! Fixed.

https://codereview.chromium.org/1382743004/diff/40001/sync/test/engine/inject...
File sync/test/engine/injectable_sync_context_proxy.cc (right):

https://codereview.chromium.org/1382743004/diff/40001/sync/test/engine/inject...
sync/test/engine/injectable_sync_context_proxy.cc:9: #include
"sync/internal_api/public/shared_model_type_processor.h"
On 2015/10/05 18:11:35, stanisc wrote:
> This class will be deleted in my change.

Acknowledged.

[stanisc, 2015-10-09 17:24:15]

lgtm

[maxbogue, 2015-10-09 17:34:38]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2015-10-09 17:35:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1382743004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1382743004/80001

[commit-bot: I haz the power, 2015-10-09 17:42:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-09 17:44:05]

Patchset 5 (id:??) landed as
https://crrev.com/786b459e828e3d593d92ccd8f1b53dee26cbe052
Cr-Commit-Position: refs/heads/master@{#353323}