Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2422)

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

Issue 1382743002: bluetooth: Add characteristicvaluechanged event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-notifications-1
Patch Set: Address tkent's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
index 481dedfdfb45cff32ab6b09aa55bb698f6745093..606f3754383d64f56a9c17a670ee9cdd6c3b3866 100644
--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
@@ -168,10 +168,20 @@ class LayoutTestBluetoothAdapterProvider {
// - Generic Access UUID (0x1800)
// - Heart Rate UUID (0x180D)
// - Heart Rate Service
+ // - Body Sensor Location
+ // - Mock Functions:
+ // - Read: Calls GattCharacteristicValueChanged and success
+ // callback with [1] which corresponds to chest.
// - Heart Rate Measurement Characteristic:
// - Mock Functions:
- // - StartNotifySession: Calls success callback with a
+ // - StartNotifySession: Sets a timer to call
+ // GattCharacteristicValueChanged every 10ms and calls success
+ // callback with a
// BaseGATTNotifySession(characteristic_instance_id)
+ // TODO: Instead of a timer we should be able to tell
+ // the fake adapter to call GattCharacteristicValueChanged
+ // from js.
+ // https://crbug.com/543884
static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
GetHeartRateAdapter();
@@ -432,7 +442,7 @@ class LayoutTestBluetoothAdapterProvider {
// - IsActive:
// Returns: true
// - Stop:
- // Run callback.
+ // Stops calling GattCharacteristicValueChanged and runs callback.
static scoped_ptr<testing::NiceMock<device::MockBluetoothGattNotifySession>>
GetBaseGATTNotifySession(const std::string& characteristic_identifier);

Powered by Google App Engine
This is Rietveld 408576698