Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3403)

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

Issue 1382743002: bluetooth: Add characteristicvaluechanged event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-notifications-1
Patch Set: Final clean up Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
index 481dedfdfb45cff32ab6b09aa55bb698f6745093..64d0f303fd37eba6f8c640099f472f241079b58b 100644
--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
@@ -168,9 +168,15 @@ class LayoutTestBluetoothAdapterProvider {
// - Generic Access UUID (0x1800)
// - Heart Rate UUID (0x180D)
// - Heart Rate Service
+ // - Body Sensor Location
+ // - Mock Functions:
+ // - Read: Calls GattCharacteristicValueChanged and success
+ // callback with [1] which corresponds to chest.
// - Heart Rate Measurement Characteristic:
// - Mock Functions:
- // - StartNotifySession: Calls success callback with a
+ // - StartNotifySession: Sets a timer to call
+ // GattCharacteristicValueChanged every 10ms and calls success
Jeffrey Yasskin 2015/10/15 23:00:51 Good hack. Can you file a bug to change this to an
ortuno 2015/10/16 01:24:21 Done.
+ // callback with a
// BaseGATTNotifySession(characteristic_instance_id)
static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
GetHeartRateAdapter();
@@ -432,7 +438,7 @@ class LayoutTestBluetoothAdapterProvider {
// - IsActive:
// Returns: true
// - Stop:
- // Run callback.
+ // Stops calling GattCharacteristicValueChanged and runs callback.
static scoped_ptr<testing::NiceMock<device::MockBluetoothGattNotifySession>>
GetBaseGATTNotifySession(const std::string& characteristic_identifier);

Powered by Google App Engine
This is Rietveld 408576698