Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 138273016: Introduce a setting to control the toolset for which d8 is compiled (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Introduce a setting to control the toolset for which d8 is compiled BUG=v8:1775 R=machenbach@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=18656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/toolchain.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M src/d8.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-17 08:12:38 UTC) #1
Michael Achenbach
On 2014/01/17 08:12:38, jochen wrote: lgtm
6 years, 11 months ago (2014-01-17 09:11:04 UTC) #2
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-17 09:11:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698