Issue 138273013: Check for duplicate ArrayBuffer transferables.

Issue 138273013: Check for duplicate ArrayBuffer transferables. (Closed)

Created:
6 years, 11 months ago by sof

Modified:
6 years, 11 months ago

Reviewers:
Dmitry Lomov (no reviews), Mike West

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Check for duplicate ArrayBuffer transferables. Attempts to pass duplicate transferable object should be caught by postMessage(), http://www.whatwg.org/specs/web-apps/current-work/#dom-window-postmessage http://www.whatwg.org/specs/web-apps/current-work/#dom-messageport-postmessage Add the required case for ArrayBuffer. R=mkwst,dslomov BUG=334397 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165224

Patch Set 1 #

Patch Set 2 : Update test to current #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
M	LayoutTests/fast/canvas/webgl/script-tests/arraybuffer-transfer-of-control.js	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/window-postmessage-clone-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/events/message-port-multi-expected.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/events/resources/message-port-multi.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/V8Utilities.cpp	View		1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mike West

Pretty straightforward, thanks. LGTM. Give Dmitry a bit of time to object, however. He knows ...

6 years, 11 months ago (2014-01-16 11:18:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/138273013/30001

6 years, 11 months ago (2014-01-16 12:04:18 UTC) #4

Message was sent while issue was closed.

Change committed as 165224

Expand Messages | Collapse Messages