Quick searches for sync-internals

Quick searches for sync-internals

Added some quick searches that are usually performed in
sync to find out which objects are not updated and have
pending updates not being done.

Currently it implements IS_UNSYNCED, IS_UNAPPLIED_UPDATE, both, and
IS_DEL.


BUG=154378
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245463

[rlarocque, 2014-01-15 23:57:17]

Here's one small comment and a few suggested renames.

The names you're using would probably make sense if clicking the links did not
actually perform the query.  Since that's no longer the case, I'd like to
suggest some alternatives.

https://codereview.chromium.org/138273009/diff/1/chrome/browser/resources/syn...
File chrome/browser/resources/sync_internals/search.js (right):

https://codereview.chromium.org/138273009/diff/1/chrome/browser/resources/syn...
chrome/browser/resources/sync_internals/search.js:11: 
nit: remove extra line.

https://codereview.chromium.org/138273009/diff/1/chrome/browser/resources/syn...
File chrome/browser/resources/sync_internals/sync_search.js (right):

https://codereview.chromium.org/138273009/diff/1/chrome/browser/resources/syn...
chrome/browser/resources/sync_internals/sync_search.js:10: var applyFilter =
function(queryControl, query) {
Would 'setQueryString' be a better name for this function?

https://codereview.chromium.org/138273009/diff/1/chrome/browser/resources/syn...
chrome/browser/resources/sync_internals/sync_search.js:14: var
createApplyFunction = function(queryControl, submitControl, query) {
Maybe rename to 'createDoQueryFunction'?

[mferreria_g, 2014-01-16 00:32:02]

https://codereview.chromium.org/138273009/diff/1/chrome/browser/resources/syn...
File chrome/browser/resources/sync_internals/search.js (right):

https://codereview.chromium.org/138273009/diff/1/chrome/browser/resources/syn...
chrome/browser/resources/sync_internals/search.js:11: 
On 2014/01/15 23:57:17, rlarocque wrote:
> nit: remove extra line.

Done.

https://codereview.chromium.org/138273009/diff/1/chrome/browser/resources/syn...
File chrome/browser/resources/sync_internals/sync_search.js (right):

https://codereview.chromium.org/138273009/diff/1/chrome/browser/resources/syn...
chrome/browser/resources/sync_internals/sync_search.js:10: var applyFilter =
function(queryControl, query) {
On 2014/01/15 23:57:17, rlarocque wrote:
> Would 'setQueryString' be a better name for this function?

Done.

https://codereview.chromium.org/138273009/diff/1/chrome/browser/resources/syn...
chrome/browser/resources/sync_internals/sync_search.js:14: var
createApplyFunction = function(queryControl, submitControl, query) {
On 2014/01/15 23:57:17, rlarocque wrote:
> Maybe rename to 'createDoQueryFunction'?

Done.

[rlarocque, 2014-01-16 00:46:43]

The changes look OK, but the latest patch looks like it's a bit smaller than it
should be.  Try clicking the '[raw]' link and you'll see what I mean.

I've started a trybot to check whether or not the latest upload is actually
broken like I think it is.

[mferreria_g, 2014-01-16 00:48:34]

On 2014/01/16 00:46:43, rlarocque wrote:
> The changes look OK, but the latest patch looks like it's a bit smaller than
it
> should be.  Try clicking the '[raw]' link and you'll see what I mean.
> 
> I've started a trybot to check whether or not the latest upload is actually
> broken like I think it is.

So the patchset should be a full patchset or just the diff between the previous
patchset and the new one? I thought it was the latter, but I now realize it may
be the former.

[rlarocque, 2014-01-16 01:00:11]

On 2014/01/16 00:48:34, mferreria wrote:
> On 2014/01/16 00:46:43, rlarocque wrote:
> > The changes look OK, but the latest patch looks like it's a bit smaller than
> it
> > should be.  Try clicking the '[raw]' link and you'll see what I mean.
> > 
> > I've started a trybot to check whether or not the latest upload is actually
> > broken like I think it is.
> 
> So the patchset should be a full patchset or just the diff between the
previous
> patchset and the new one? I thought it was the latter, but I now realize it
may
> be the former.

The second patchset should be diffed against the same revision as the first one
was.

[rlarocque, 2014-01-16 01:06:08]

lgtm

[commit-bot: I haz the power, 2014-01-16 21:46:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mferreria@google.com/138273009/150001

[commit-bot: I haz the power, 2014-01-17 02:50:57]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-17 05:25:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mferreria@google.com/138273009/150001

[commit-bot: I haz the power, 2014-01-17 07:18:10]

Change committed as 245463