Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: tools/gn/secondary/third_party/snappy/BUILD.gn

Issue 138273007: Convert GN single-item list concat to use lists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/secondary/third_party/sfntly/BUILD.gn ('k') | tools/gn/secondary/third_party/zlib/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/secondary/third_party/snappy/BUILD.gn
diff --git a/tools/gn/secondary/third_party/snappy/BUILD.gn b/tools/gn/secondary/third_party/snappy/BUILD.gn
index ba1a7b4089238ea63f635f2c06e1568ad9916577..66f6f5b047db8f4dd0643fb2f9630a9b49b6b299 100644
--- a/tools/gn/secondary/third_party/snappy/BUILD.gn
+++ b/tools/gn/secondary/third_party/snappy/BUILD.gn
@@ -10,11 +10,11 @@ config("snappy_config") {
# These OS-specific generated headers were made by running the configure
# script offline.
if (is_win) {
- include_dirs += "win32"
+ include_dirs += [ "win32" ]
} else if (is_mac) {
- include_dirs += "mac"
+ include_dirs += [ "mac" ]
} else {
- include_dirs += "linux"
+ include_dirs += [ "linux" ]
}
}
@@ -29,8 +29,8 @@ static_library("snappy") {
"src/snappy.h",
]
- configs -= "//build/config/compiler:chromium_code"
- configs += "//build/config/compiler:no_chromium_code"
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
direct_dependent_configs = [ ":snappy_config" ]
#['OS=="win"', {
@@ -60,8 +60,8 @@ test("snappy_unittest") {
"src/snappy_unittest.cc",
]
- configs -= "//build/config/compiler:chromium_code"
- configs += "//build/config/compiler:no_chromium_code"
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
deps = [
":snappy",
« no previous file with comments | « tools/gn/secondary/third_party/sfntly/BUILD.gn ('k') | tools/gn/secondary/third_party/zlib/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698