Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: base/BUILD.gn

Issue 138273007: Convert GN single-item list concat to use lists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 2d83ba18e0ff3829253ed6b32e218057519a78c3..8e7471a5a2afd938324c7b393c3b183435b2a996 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -674,7 +674,7 @@ component("base") {
]
# TODO(brettw) I don't understand the conditions this file is used.
- sources -= "files/file_path_watcher_stub.cc"
+ sources -= [ "files/file_path_watcher_stub.cc" ]
sources -= [
# TODO(brettw) do these properly.
@@ -752,12 +752,12 @@ component("base") {
]
if (is_component_build) {
- sources -= "debug/debug_on_start_win.cc"
+ sources -= [ "debug/debug_on_start_win.cc" ]
}
} else if (!is_nacl) {
# Non-Windows.
- deps += "//third_party/libevent"
- libs += "dl"
+ deps += [ "//third_party/libevent" ]
+ libs += [ "dl" ]
}
# Mac.
@@ -767,7 +767,7 @@ component("base") {
"native_library_posix.cc",
"strings/sys_string_conversions_posix.cc",
]
- deps += "//third_party/mach_override"
+ deps += [ "//third_party/mach_override" ]
libs += [
"AppKit.framework",
"ApplicationServices.framework",
@@ -779,7 +779,7 @@ component("base") {
]
} else {
# Non-Mac.
- sources -= "files/file_path_watcher_kqueue.cc"
+ sources -= [ "files/file_path_watcher_kqueue.cc" ]
}
# IOS.
@@ -883,7 +883,7 @@ component("base_i18n") {
if (toolkit_uses_gtk) {
# i18n/rtl.cc uses gtk
- configs += "//build/config/linux:gtk"
+ configs += [ "//build/config/linux:gtk" ]
}
#'conditions': [
« no previous file with comments | « no previous file | base/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698