Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 138273006: Invokes SchedulePaint when animation ended to repaint the background. (Closed)

Created:
6 years, 11 months ago by Jun Mukai
Modified:
6 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Invokes SchedulePaint when animation ended to repaint the background. BUG=334461 R=xiyuan@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245163

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M ui/app_list/views/app_list_view.cc View 1 4 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jun Mukai
6 years, 11 months ago (2014-01-15 00:49:14 UTC) #1
xiyuan
LGTM https://codereview.chromium.org/138273006/diff/1/ui/app_list/views/app_list_view.cc File ui/app_list/views/app_list_view.cc (right): https://codereview.chromium.org/138273006/diff/1/ui/app_list/views/app_list_view.cc#newcode114 ui/app_list/views/app_list_view.cc:114: parent_->SchedulePaint(); Think we should use app_list_view_->GetBubbleFrameView()->SchedulePaint() because the ...
6 years, 11 months ago (2014-01-15 01:22:05 UTC) #2
Jun Mukai
https://codereview.chromium.org/138273006/diff/1/ui/app_list/views/app_list_view.cc File ui/app_list/views/app_list_view.cc (right): https://codereview.chromium.org/138273006/diff/1/ui/app_list/views/app_list_view.cc#newcode114 ui/app_list/views/app_list_view.cc:114: parent_->SchedulePaint(); On 2014/01/15 01:22:05, xiyuan wrote: > Think we ...
6 years, 11 months ago (2014-01-15 02:03:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/138273006/60001
6 years, 11 months ago (2014-01-15 05:54:24 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 06:15:54 UTC) #5
Message was sent while issue was closed.
Change committed as 245163

Powered by Google App Engine
This is Rietveld 408576698