Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 138273003: Fix TestGCScope in blink_heap_unittests so that it leaves freelists alone. (Closed)

Created:
6 years, 11 months ago by Mads Ager (chromium)
Modified:
6 years, 11 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Fix TestGCScope in blink_heap_unittests so that it leaves freelists alone. The TestGCScope only needs to stop and resume threads. It should not change the state of the heap. The old code made the heap consistent for scanning which cleared all freelists and never rebuild them. R=haraken@chromium.org, erik.corry@gmail.com, wibling@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/heap/HeapTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (chromium)
6 years, 11 months ago (2014-01-14 17:43:26 UTC) #1
Mads Ager (chromium)
This was uncovered by the tests that Gustav is moving over in one of his ...
6 years, 11 months ago (2014-01-14 17:44:42 UTC) #2
haraken
LGTM
6 years, 11 months ago (2014-01-15 00:22:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/138273003/1
6 years, 11 months ago (2014-01-15 06:40:41 UTC) #4
Mads Ager (chromium)
6 years, 11 months ago (2014-01-15 06:58:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r165109 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698