Issue 1382683008: Merge to XFA: Store object definition ID in each js_class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1382683008: Merge to XFA: Store object definition ID in each js_class. (Closed)

Created:
5 years, 2 months ago by Tom Sepez

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Store object definition ID in each js_class. Manual edits in JS_Define.h. (cherry picked from commit f0a5b2803c09f3605dcd606e764ef604f0d2a8ea) Original Review URL: https://codereview.chromium.org/1382263002 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/cd56a7d6fb05bd0babf316a84280a26ecc649d45

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+288 lines, -359 lines)			Patch
M	fpdfsdk/include/jsapi/fxjs_v8.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	1	7 chunks	+8 lines, -20 lines	0 comments	Download
M	fpdfsdk/src/javascript/Field.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/Field.cpp	View	1	2 chunks	+4 lines, -6 lines	0 comments	Download
M	fpdfsdk/src/javascript/Icon.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Define.h	View	1	7 chunks	+171 lines, -163 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_EventHandler.cpp	View	1	2 chunks	+12 lines, -14 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	1	3 chunks	+21 lines, -22 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View	1	5 chunks	+32 lines, -62 lines	0 comments	Download
M	fpdfsdk/src/javascript/color.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/console.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/event.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/report.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/util.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View		6 chunks	+25 lines, -51 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

5 years, 2 months ago (2015-10-06 18:45:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
cd56a7d6fb05bd0babf316a84280a26ecc649d45 (presubmit successful).

Expand Messages | Collapse Messages